fix(front): make notifications page span full width - #1777
Conversation
Signed-off-by: Hsukqi Lee <team@tsinbei.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe stylesheet adds a full-width rule for the notifications content section inside its flex container. ChangesNotifications layout
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Notifications content now fills the available page width as intended, with no identified merge-readiness risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📌 Description
The notifications page content does not span the full width, unlike the other Monitoring pages (#1762). Root cause: the page wrapper
#notificationsis a flex container (front/css/app.css), so its child<section class="content table-responsive">is a flex item and shrinks to its content width instead of stretching like on the other pages.This adds a scoped rule stretching the content section to the wrapper's full width:
Skeleton check requested in the issue:
#notifications-skeletonis absolutely positioned withleft: 0; right: 0(plus the samemargin: 15pxused by the other pages' skeletons), so it already covers the full page width during load and is unaffected by this change.🔍 Related Issues
fixes #1762
📋 Type of Change
📷 Screenshots or Logs (if applicable)
CSS-only change; the notifications table/box now stretches to the wrapper width, matching e.g. the Events/Presence pages.
🧪 Testing Steps
#notifications { display: flex }makessection.contenta shrink-to-fit flex item; addingwidth: 100%restores full width. The skeleton overlay usesposition: absolute; left: 0; right: 0, so it remains full width during loading.#notifications .contentonly; no other page uses this selector.test/ui/test_ui_notifications.py) locally as it requires a running instance; happy to adjust if CI/maintainer testing shows anything.✅ Checklist
🙋 Additional Notes
If you would prefer removing
display: flexfrom#notificationsentirely instead of stretching the child, I am happy to rework — I kept the flex container in place to avoid disturbing the skeleton/spinner overlay behavior.Summary by CodeRabbit