Let the resources search field take focus on a television - #255
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Android TV branch of Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change allows the resources search field to receive focus on Android TV without changing other search behavior. No actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cb3f380 to
16cc00c
Compare
The resources list disables focus on its search field when running on a television, which leaves a field that is drawn, looks editable, and can never be used: it cannot take D-pad focus, so it can never open the keyboard or hold a cursor.
Focus alone does not raise a keyboard on a television, since that needs an explicit select, so the field can be reachable without getting in the way of navigating to the list below it.
The peers list does the same thing to its own search field and filter icon, and the comment there attributes it to a navigation drawer that no longer exists in the app. Left alone here to keep this change to one screen; worth deciding separately whether that one should follow.