Skip to content

Let the resources search field take focus on a television - #255

Merged
lixmal merged 1 commit into
ux/ios-style-redesignfrom
tv-resources-search-focus
Sep 3, 2026
Merged

Let the resources search field take focus on a television#255
lixmal merged 1 commit into
ux/ios-style-redesignfrom
tv-resources-search-focus

Conversation

@lixmal

@lixmal lixmal commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The resources list disables focus on its search field when running on a television, which leaves a field that is drawn, looks editable, and can never be used: it cannot take D-pad focus, so it can never open the keyboard or hold a cursor.

Focus alone does not raise a keyboard on a television, since that needs an explicit select, so the field can be reachable without getting in the way of navigating to the list below it.

  • Stop disabling focus on the resources search field on Android TV

The peers list does the same thing to its own search field and filter icon, and the comment there attributes it to a navigation drawer that no longer exists in the app. Left alone here to keep this change to one screen; worth deciding separately whether that one should follow.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 770a3ff8-8720-4b90-bd07-8a00b2ae1108

📥 Commits

Reviewing files that changed from the base of the PR and between c9ab37e and cb3f380.

📒 Files selected for processing (1)
  • app/src/main/java/io/netbird/client/ui/home/NetworksFragment.java
💤 Files with no reviewable changes (1)
  • app/src/main/java/io/netbird/client/ui/home/NetworksFragment.java

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Android TV branch of NetworksFragment no longer disables focusability for the search view.

Changes

Cohort / File(s) Summary
Android TV search focus
app/src/main/java/io/netbird/client/ui/home/NetworksFragment.java
Removed calls that disabled search view focusability on Android TV.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cb3f3

This localized change allows the resources search field to receive focus on Android TV without changing other search behavior. No actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit hops where focus can stay
The search view greets the day
Two blockers vanish from the screen
Android TV keeps focus clean
Networks bloom in gentle light

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: allowing the resources search field to receive focus on Android TV.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tv-resources-search-focus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lixmal
lixmal force-pushed the tv-resources-search-focus branch from cb3f380 to 16cc00c Compare September 2, 2026 10:25
@lixmal
lixmal changed the base branch from main to ux/ios-style-redesign September 2, 2026 10:25
@lixmal
lixmal requested a review from pappz September 2, 2026 14:50
@lixmal
lixmal merged commit e9afdcc into ux/ios-style-redesign Sep 3, 2026
7 checks passed
@lixmal
lixmal deleted the tv-resources-search-focus branch September 3, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants