Remove solutions engineer booking modal from onboarding

[SunsetDrifter]

Issue ticket number and link

None — requested directly: users are still booking solutions engineer meetings from the dashboard, so the entry point is being removed.

Documentation

Select exactly one:

• I added/updated documentation for this change
• Documentation is not needed for this change (explain why)

This removes an internal onboarding growth experiment. The modal was never documented in netbirdio/docs, and no user-facing feature or configuration surface changes.

Docs PR URL (required if "docs added" is checked)

n/a

Change

The onboarding survey opened a HubSpot booking modal (meetings-eu1.hubspot.com/jack81/selfserve45-dashboard) whenever the planned_users field came back as 50 or more. This removes that flow:

• Deletes OnboardingDemoCall.tsx, including the six onboarding-call experiment variants.
• Removes the demoCallModal state, the modal render, and the planned_users >= 50 trigger from Onboarding.tsx.
• Deletes the avatar asset the modal was the only consumer of.

Survey behaviour is otherwise untouched — planned_users is still collected and submitted to HubSpot, and the use_case / is_company reads that feed the intent step are unchanged. Step progression is unaffected.

useExperiment.ts is left in place for a future experiment, even though this was its only caller.

Two things this PR deliberately does not cover: the HubSpot scheduling page is still live, so existing bookmarked links keep working until it is disabled there, and old onboarding-call variant assignments remain under the netbird-experiments localStorage key in users' browsers.

Summary by CodeRabbit

• Removed Features
  • Removed the demo-call booking prompt and modal from the onboarding flow.
  • Onboarding survey submission no longer triggers demo-call offers based on company size.
  • Removed related experiment variations, tracking, and booking interactions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The onboarding flow no longer opens a demo-call modal after survey submission. The demo-call component, experiment variants, analytics tracking, booking flow, and modal UI were removed.

Changes

Onboarding demo-call removal

Layer / File(s)	Summary
Remove demo-call onboarding flow src/modules/onboarding/Onboarding.tsx, src/modules/onboarding/OnboardingDemoCall.tsx	The onboarding module removes demo-call imports, state, survey handling, and rendering. The OnboardingDemoCall component is deleted with its experiment variants, analytics tracking, booking flow, and modal UI.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit with a tidy trail,
No demo-call modal in the mail.
Survey steps now simply end,
Old booking paths no longer bend.
Clean onboarding, hop and cheer!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the solutions engineer booking modal from onboarding.
Description check	✅ Passed	The description covers the issue context, documentation decision, implementation details, unchanged behavior, and deliberate out-of-scope items.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/remove-onboarding-demo-call

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}