build: use npm ci for clean, reproducible installs#839
Merged
Conversation
Switch pr-build and the Docker image from `npm install` to `npm ci` (`npm ci --omit=dev` in the image), and enable setup-node's npm cache. Deterministic installs from the committed lockfile; CI now fails fast on an out-of-sync lockfile. Depends on the lockfile being tracked (PR #838) — npm ci requires a committed package-lock.json.
Contributor
📝 WalkthroughWalkthroughThe PR build workflow now caches npm dependencies via ChangesLockfile-based npm installs
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnfrati
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that the lockfile is tracked (#838), switch installs to
npm cifor clean, deterministic, lockfile-pinned installs. Third of the docs build/deploy speed series.What
pr-build.yml:npm install→npm ci, and enablesetup-node'scache: 'npm'(caches~/.npmkeyed on the lockfile).docker/Dockerfile:npm install --production→npm ci --omit=dev.Impact
^ranges).Testing
Ran both install paths in an isolated dir (did not touch the repo's
node_modules):npm ci --omit=dev(Docker path): exit 0;next16.1.6, react, shiki present; eslint/prettier correctly omitted.npm ci(pr-build path): exit 0; devDeps present.Depends on
Test plan
npm ciin sync with committed lockfile (both--omit=devand full)pr-buildCI greenSummary by CodeRabbit