Document behavior of multiple separate exit nodes - #954
Merged
Conversation
Replaces the 'does not work: ... no coordinated selection' claim in Regional Exit Nodes with the verified behavior: separate exit nodes appear as independent choices in the device's exit node selector, the client auto-selects the alphabetically first name (metrics and latency play no part), and there is no failover between exit nodes - a device whose selected exit node loses its routing peer keeps it selected and loses internet entirely, even across reconnects. Adds the matching non-overlapping-distribution-groups caveat to the per-group placement advice, and aligns 'exit node entry' wording to plain 'exit node'.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SunsetDrifter
marked this pull request as ready for review
August 27, 2026 11:09
TechHutTV
self-requested a review
August 27, 2026 12:10
TechHutTV
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Regional Exit Nodes section currently says adding regions as separate exit nodes "does not work: metrics and nearest-peer selection only apply between routing peers of the same route, so separate entries give every device both default routes with no coordinated selection." The last part is not what happens, and the actual behavior is worse in a way admins should know about:
This PR replaces the sentence with the verified behavior, adds a matching caveat to the per-group placement advice (keep distribution groups from overlapping; manual regional choice is the one case where separate exit nodes are right), and aligns the remaining "exit node entry" wording to plain "exit node".
Behavior verified against NetBird Cloud with client 0.77.1, three separate 0/0 exit nodes applied to one peer: reversed metric orderings, extended router-down watches, fresh reconnects while down, and name-vs-creation-order discriminators.
Related: internal discussion about whether auto-apply should be allowed on multiple exit node objects at all; this documents current behavior either way.