Increase garbage collection on ios - #1981
Merged
Merged
Conversation
pascal-fischer
marked this pull request as ready for review
May 15, 2024 08:10
pappz
reviewed
May 15, 2024
| return nil, err | ||
| } | ||
|
|
||
| runtime.GC() |
Collaborator
There was a problem hiding this comment.
Is it necessary for all operation systems?
Collaborator
Author
There was a problem hiding this comment.
Not necessary but having it running after each established connection might be good for memory in other OS as well
pappz
previously approved these changes
May 15, 2024
mlsmaycon
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The iOS app only allows to connect to a limited number of peers before it reaches its memory limits (currently 50MB for the network extension). This PR is the first step in optimizing the memory usage for iOS by increasing the garbage collection.
Issue ticket number and link
#1899 (comment)
Checklist