Skip to content

Update Caddyfile and Docker Compose to support HTTP3 - #2822

Merged
mlsmaycon merged 1 commit into
netbirdio:mainfrom
v1rusnl:patch-1
Nov 30, 2024
Merged

Update Caddyfile and Docker Compose to support HTTP3#2822
mlsmaycon merged 1 commit into
netbirdio:mainfrom
v1rusnl:patch-1

Conversation

@v1rusnl

@v1rusnl v1rusnl commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

Describe your changes

Update Caddyfile and Docker Compose to support HTTP3

Issue ticket number and link

Closes #2785

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • [X ] Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sonarqubecloud

Copy link
Copy Markdown

@CLAassistant

CLAassistant commented Oct 31, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mlsmaycon
mlsmaycon merged commit e52d352 into netbirdio:main Nov 30, 2024
networks: [ netbird ]
ports:
- '443:443'
- '443:443/udp'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1rusnl could you clarify whether this is necessary at all? To my knowledge the default ports rule should encompass both TCP and UDP

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the official docker documentation, just the TCP Port is mapped by default if no protocol is appended. 443:443 is 443:443/tcp by default to my knowledge. UDP must be specified. HTTP3/QUIC did not work with the NetBird UI unless 443:443/udp was explicitely specified in Compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard UI HTTP3

4 participants