Adding --external-ip-map and --dns-resolver-address and shorthand flags - #652
Merged
Conversation
mlsmaycon
changed the title
mlsmaycon
marked this pull request as ready for review
January 15, 2023 11:49
Collaborator
Author
|
Still a pain to add new flags mainly caused by the current behavior and daemon communication. It might make sense for us to refactor this whole thing or change the behavior for updating daemon settings |
# Conflicts: # client/cmd/up.go
Updated Dockerfile with new flag
braginini
requested changes
Jan 17, 2023
braginini
approved these changes
Jan 17, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
…gs (netbirdio#652) Adding --external-ip-map and --dns-resolver-address to up command and shorthand option to global flags. Refactor get and read config functions with new ConfigInput type. updated cobra package to latest release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding --external-ip-map and --dns-resolver-address to
upcommand and shorthand option to global flags.updated reference doc with new flags here: netbirdio/docs#28
Refactor get and read config functions with new ConfigInput type.
updated cobra package to latest release.
Issue ticket number and link
#585
Checklist