Fallback to console log when can't write log file - #689
Closed
braginini wants to merge 2 commits into
Closed
Conversation
pappz
reviewed
Feb 15, 2023
| } | ||
|
|
||
| logPath = "/tmp/netbird/netbird/netbird.log" | ||
| if logPath != "" && logPath != "console" { |
Collaborator
There was a problem hiding this comment.
I recommend to move this scope into a new function. And always good idea to avoid the deep if-else statements.
I. e.
if logPath == "" {
return
}
if logPath == "console" {
return
}
if !canWrite {
return
}
...
Collaborator
There was a problem hiding this comment.
I point to the 25. line. Sry
Collaborator
Author
|
we will close this PR. @mlsmaycon found a better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Skip writing log file when permissions don't allow write operations.
Fallback to CONSOLE log output.
Issue ticket number and link
Checklist