Revert private cache enabled by default#2003
Merged
Merged
Conversation
…ault" This reverts commit caa7ad8.
grep "cache" -L $(grep "redirect" -iL $(grep "whitelist" -RL))
Collaborator
|
I agree. For those of us who want it globally, we can just add |
Owner
|
Reverted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit caa7ad8 enabled private-cache by default globally.
Should this really be enabled by default? Preventing programs from having persistent cache directories overall has many negative impacts.
I think it'd be better if we just manually add
private-cacheonly to suitable programs.private-cache will need to be added to more programs as identified by