-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
status: duplicateThis issue has already been raisedThis issue has already been raisedtype: housekeepingChanges to the application which do not directly impact the end userChanges to the application which do not directly impact the end user
Description
Proposed Changes
We have several at least one django_tables.Table sub-class that uses the . notation to specify related objects. This notation was deprecated in django-tables2 v2.2.0 in favor of using the __ notation.
For example, in circuits.tables.CircuitTerminationTable we define a column provider that uses accessor='circuit.provider'. This will become accessor='circuit__provider'.
--> find . -iname "*.py" | xargs rg "accessor=.*[\'\"].*\."
./circuits/tables/circuits.py
114: accessor='circuit.provider'
Justification
This will have a couple of positive effects:
- It's required for the django-tables2 3.0 release, so will ease our upgrade path when the time comes.
- It will eliminate unnecessary chatter in test output.
Metadata
Metadata
Assignees
Labels
status: duplicateThis issue has already been raisedThis issue has already been raisedtype: housekeepingChanges to the application which do not directly impact the end userChanges to the application which do not directly impact the end user