Bump dotnet-sdk from 10.0.102 to 10.0.103#1
Closed
dependabot[bot] wants to merge 1 commit intodevfrom
Closed
Conversation
Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 10.0.102 to 10.0.103. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v10.0.102...v10.0.103) --- updated-dependencies: - dependency-name: dotnet-sdk dependency-version: 10.0.103 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
This was referenced Feb 28, 2026
Author
|
Superseded by #199. |
auto-merge was automatically disabled
March 11, 2026 03:45
Pull request was closed
4 tasks
Aaronontheweb
added a commit
that referenced
this pull request
Apr 11, 2026
…ema init Five related cleanups surfaced during the /simplify review of the `remove-domain-migration` branch. Each was defensive code that papered over a latent bug or was cleaning up shapes no current write path produces. 1. Delete hygiene UPDATE #1 (turn-completion/ConversationTrace → Never) and the defensive filters/ranker penalties keyed on them. `MemoryCurationPipeline.Extract` early-returns on TurnComplete+!Explicit and only emits "Project Fact:" / "Project Milestone:" titles — nothing currently writes `title='turn-completion'` to memory_documents. 2. Delete hygiene UPDATE #2 (metadata backfill for malformed doc:% titles) plus the pinning test `InitializeAsync_demotes_malformed_auto_recall_ documents_to_searchable` and the `MissingMetadataFacet` constant. 3. Replace the startup FTS rebuild (unconditional DROP + CREATE VIRTUAL TABLE + full INSERT ... SELECT, O(rows) every boot) with `CREATE VIRTUAL TABLE IF NOT EXISTS`. To make this safe, fix the runtime FTS write paths that the rebuild was papering over: - `InsertDocumentFtsAsync` / `InsertRecordFtsAsync` → rename to `UpsertDocumentFtsAsync` / `UpsertRecordFtsAsync`, DELETE-then-INSERT so repeat upserts do not leave duplicate FTS rows - `TombstoneDocumentAsync` now deletes the FTS row - `SupersedeRecordAsync` now deletes the old record's FTS row - Fix two raw-string-literal SQL interpolation bugs (`TombstoneDocumentAsync`, `SupersedeRecordAsync`) where the missing `$` prefix caused `{MemoryUpdateSemantics.*.ToWireValue()}` to be written literally into the column. 4. Unify startup schema ordering. Move `SchemaMigrationHostedService` registration before memory services so its StartAsync runs before `MemoryCurationWorkerService`. Delete the synchronous `memoryStore.InitializeAsync(...).GetAwaiter().GetResult()` at DI registration time. Have the hosted service call both the versioned migrator and `SQLiteMemoryStore.InitializeAsync` in sequence so there is exactly one startup path for schema setup.
Aaronontheweb
added a commit
that referenced
this pull request
Apr 11, 2026
* refactor(memory): drop domain-column migration from InitializeAsync The fresh CREATE TABLE schema is already domain-free. The DROP COLUMN / DROP INDEX migration and the DropColumnIfExistsAsync/DropIndexIfExistsAsync helpers were only there for backward compatibility with existing user DBs, which is unnecessary — the store is single-user and the DB is disposable. * refactor(memory): drop EnsureColumnExistsAsync dead migration helpers Every column being "ensured" in InitializeAsync (memory_class, expires_at, aliases_json, facets_json, slots_json, boundary, audience on both memory_documents and memory_records) is already declared in the CREATE TABLE statements in the same method. On every daemon startup the 14 calls issued 14 redundant PRAGMA table_info scans for columns that always existed on fresh installs. Same reasoning as the DROP COLUMN cleanup: single-user prototype, disposable DB, no backward-compat requirement. * refactor(memory): clean up dead hygiene, fix FTS lifecycle, unify schema init Five related cleanups surfaced during the /simplify review of the `remove-domain-migration` branch. Each was defensive code that papered over a latent bug or was cleaning up shapes no current write path produces. 1. Delete hygiene UPDATE #1 (turn-completion/ConversationTrace → Never) and the defensive filters/ranker penalties keyed on them. `MemoryCurationPipeline.Extract` early-returns on TurnComplete+!Explicit and only emits "Project Fact:" / "Project Milestone:" titles — nothing currently writes `title='turn-completion'` to memory_documents. 2. Delete hygiene UPDATE #2 (metadata backfill for malformed doc:% titles) plus the pinning test `InitializeAsync_demotes_malformed_auto_recall_ documents_to_searchable` and the `MissingMetadataFacet` constant. 3. Replace the startup FTS rebuild (unconditional DROP + CREATE VIRTUAL TABLE + full INSERT ... SELECT, O(rows) every boot) with `CREATE VIRTUAL TABLE IF NOT EXISTS`. To make this safe, fix the runtime FTS write paths that the rebuild was papering over: - `InsertDocumentFtsAsync` / `InsertRecordFtsAsync` → rename to `UpsertDocumentFtsAsync` / `UpsertRecordFtsAsync`, DELETE-then-INSERT so repeat upserts do not leave duplicate FTS rows - `TombstoneDocumentAsync` now deletes the FTS row - `SupersedeRecordAsync` now deletes the old record's FTS row - Fix two raw-string-literal SQL interpolation bugs (`TombstoneDocumentAsync`, `SupersedeRecordAsync`) where the missing `$` prefix caused `{MemoryUpdateSemantics.*.ToWireValue()}` to be written literally into the column. 4. Unify startup schema ordering. Move `SchemaMigrationHostedService` registration before memory services so its StartAsync runs before `MemoryCurationWorkerService`. Delete the synchronous `memoryStore.InitializeAsync(...).GetAwaiter().GetResult()` at DI registration time. Have the hosted service call both the versioned migrator and `SQLiteMemoryStore.InitializeAsync` in sequence so there is exactly one startup path for schema setup. * fix(memory): unconditional memory init + atomic FTS lifecycle Two regressions introduced by the previous cleanup commit, caught by /simplify review: 1. SchemaMigrationHostedService.StartAsync early-returned when the akka persistence provider wasn't SQLite or auto-migrate was disabled, which silently skipped _memoryStore.InitializeAsync(). The memory store always uses SQLite regardless of akka persistence config, so its schema init now runs unconditionally outside the guard. 2. TombstoneDocumentAsync, SupersedeRecordAsync, and UpdateDocumentTextAsync ran the base-table UPDATE/INSERT and the FTS delete/insert as two separate implicit transactions. Before this branch the startup FTS rebuild cleaned up any drift; with the rebuild gone, a crash between the two statements leaves FTS stale (tombstoned doc still searchable, superseded record's old row orphaned). Wrap each path in an explicit BeginTransaction/Commit so both writes land together or neither does.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dotnet-sdk from 10.0.102 to 10.0.103.
Release notes
Sourced from dotnet-sdk's releases.
Commits
2f84158[release/10.0.1xx] Source code updates from dotnet/dotnet (#52573)723b9d5Update dependenciese6a41ba[automated] Merge branch 'release/9.0.3xx' => 'release/10.0.1xx' (#52375)c08a02a[release/10.0.1xx] Update dependencies from microsoft/testfx (#52536)3a0defdUpdate dependencies from https://github.com/microsoft/testfx build 20260118.4171977b[release/10.0.1xx] Update dependencies from microsoft/testfx (#52521)6404a34[release/10.0.1xx] Bump analysislevel constants for .NET 10 release (#52511)dcff850Update dependencies from https://github.com/microsoft/testfx build 20260117.2a39c37bUpdate dependencies from https://github.com/microsoft/testfx build 20260116.27218b01[release/10.0.1xx] Update dependencies from microsoft/testfx (#52500)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)