Use ShellSyntaxTree v0.3 for Bash approvals - #1835
Merged
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
August 9, 2026 04:30
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Aaronontheweb
force-pushed
the
feature/shell-syntax-tree-v03-approval
branch
from
August 9, 2026 04:57
42fdd72 to
3086a3d
Compare
Comment on lines
+236
to
+243
| foreach (var segment in relative.Split( | ||
| [Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar], | ||
| StringSplitOptions.RemoveEmptyEntries)) | ||
| { | ||
| var candidate = Path.Combine(current, segment); | ||
| current = new DirectoryInfo(candidate).ResolveLinkTarget(returnFinalTarget: true)?.FullName | ||
| ?? candidate; | ||
| } |
Comment on lines
+743
to
+750
| foreach (var segment in relative.Split( | ||
| [Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar], | ||
| StringSplitOptions.RemoveEmptyEntries)) | ||
| { | ||
| var candidate = Path.Combine(current, segment); | ||
| current = new DirectoryInfo(candidate).ResolveLinkTarget(returnFinalTarget: true)?.FullName | ||
| ?? candidate; | ||
| } |
| [Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar], | ||
| StringSplitOptions.RemoveEmptyEntries)) | ||
| { | ||
| var candidate = Path.Combine(current, segment); |
| [Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar], | ||
| StringSplitOptions.RemoveEmptyEntries)) | ||
| { | ||
| var candidate = Path.Combine(current, segment); |
| string[] expectedScopeNames) | ||
| { | ||
| var root = Path.Combine(Path.GetTempPath(), $"netclaw-path-scopes-{Guid.NewGuid():N}"); | ||
| var root = Path.Combine(CanonicalTemporaryDirectory(), $"netclaw-path-scopes-{Guid.NewGuid():N}"); |
| [Fact(SkipUnless = nameof(IsPosix), Skip = "POSIX-only path semantics")] | ||
| public void Redirect_to_symlink_target_fails_closed() | ||
| { | ||
| var root = Path.Combine(CanonicalTemporaryDirectory(), $"netclaw-redirect-symlink-{Guid.NewGuid():N}"); |
Aaronontheweb
force-pushed
the
feature/shell-syntax-tree-v03-approval
branch
from
August 9, 2026 05:08
3086a3d to
655023b
Compare
Aaronontheweb
force-pushed
the
feature/shell-syntax-tree-v03-approval
branch
from
August 9, 2026 05:29
655023b to
42d3172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo bash -lccannot bypass the hard denyCurrent alpha boundary
This change covers the grammar in 0.3.0-alpha. It keeps the #1795 numeric-operand containment until a later prerelease includes the new Bash mutation work. Loop and mutation acceptance cases will follow that package update.
Validation
dotnet build Netclaw.slnx -c Release --no-restore --verbosity minimaldotnet test Netclaw.slnx -c Release --no-build --no-restore