fix(journal-log-writer): accept only absolute journal directory paths.

[vkalintiris]

SSIA.

---

Summary by cubic

Reject non-absolute journal directories at Log::new in journal-log-writer to fail fast with a clear error and avoid dropped logs on first write.

• Bug Fixes

  • Validate that journal_dir is absolute before any I/O; return WriterError::InvalidPath naming the value.
  • Clarify file-creation failure message when a generated path can’t be parsed as a journal file.
  • Add tests for rejecting relative paths, accepting absolute paths, and creating missing absolute directories.
  • Add a directory-contract spec and note the absolute-path requirement in the OTEL plugin config; relative-path resolution remains a consumer responsibility.

• Migration

  • Ensure logs.journal_dir is an absolute path (including NETDATA_OTEL_LOGS_JOURNAL_DIR overrides); relative values now fail at startup.

^{Written for commit 48900ed. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

Architecture diagram

sequenceDiagram
    participant Config as OTEL Plugin Config
    participant Env as Environment
    participant Plugin as OTEL Plugin
    participant Log as Log::new()
    participant FS as Filesystem
    participant Chain as OwnedChain
    participant Repo as repository::File::from_path()

    Note over Config,Repo: Journal Directory Validation Flow

    Config->>Plugin: journal_dir (may be absolute from @logdir_POST@ or relative override)
    Env->>Plugin: NETDATA_OTEL_LOGS_JOURNAL_DIR override (may be relative)

    Plugin->>Log: new(journal_dir, config)

    alt journal_dir is absolute
        Log->>FS: canonicalize() to verify accessibility
        FS-->>Log: canonical path
        Note over Log: Proceed with journal creation
        Log->>FS: load_machine_id()
        FS-->>Log: machine ID
        Log->>Chain: create_chain(path)
        Chain->>FS: create directory if not exists
        FS-->>Chain: directory created
        Chain->>Repo: from_path() on generated file path
        note over Chain,Repo: CHANGED: clearer error message on parse failure
        alt file path parseable
            Repo-->>Chain: valid File
            Chain-->>Log: OwnedChain
            Log-->>Plugin: Ok(Log)
        else file path not parseable
            Repo-->>Chain: error
            Chain-->>Log: WriterError::FileCreation with detailed message
            Log-->>Plugin: Error
        end
    else journal_dir is relative
        Log-->>Plugin: CHANGED: WriterError::InvalidPath with offending value
        Note over Log,Plugin: Fail-fast before any I/O - no directory created
    end

    Note over Config,Plugin: Consumer Responsibility
    alt NetFlow Plugin path
        Note over Config,Plugin: NetFlow resolves relative path vs NETDATA_CACHE_DIR before calling Log::new
    end

Loading

_{Re-trigger cubic}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud