build(packaging): enable scripts.d plugin by default - #22892
Merged
ilyam8 merged 2 commits intoJun 29, 2026
Conversation
Static (makeself) and Docker build via netdata-installer.sh, which defaults ENABLE_SCRIPTS=0 and passes -DENABLE_PLUGIN_SCRIPTS=Off, overriding the CMake ON default. As a result scripts.d shipped only in native DEB/RPM packages (build-package.sh sets ENABLE_PLUGIN_SCRIPTS On). Pass --enable-plugin-scripts in both build invocations so static and docker ship the plugin too. scripts.d is Go-based and the Go toolchain is already required by both builds, so there is no new build dependency.
github-actions
Bot
added
the
area/packaging
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Build as Build System (Docker/Makeself)
participant Installer as netdata-installer.sh
participant Agent as Netdata Agent (Runtime)
participant Plugin as scripts.d Plugin
participant Scripts as User‑supplied Scripts
Note over Build,Scripts: scripts.d plugin is now included in static and Docker builds
Build->>Installer: Invoke with --enable-plugin-scripts
Installer->>Installer: Compile Netdata with scripts.d enabled
Installer-->>Build: Netdata binary + plugins (static/Docker artifact)
Note over Agent,Scripts: Runtime (after artifact deployed)
Agent->>Agent: Start Netdata
Agent->>Plugin: Load scripts.d plugin
Plugin->>Scripts: Execute configured shell scripts
Scripts-->>Plugin: Return metrics / alarm status
Plugin-->>Agent: Provide collected data
alt No scripts deployed
Plugin->>Plugin: Idle (no scripts to run)
end
ilyam8
enabled auto-merge (squash)
June 29, 2026 11:46
The previous commit added --enable-plugin-scripts to the static and docker build invocations. netdata-installer.sh always passes an explicit -DENABLE_PLUGIN_SCRIPTS to CMake via enable_feature, so the CMake ON default is never used by installer-based builds; the installer default ENABLE_SCRIPTS=0 is the actual lever. Default ENABLE_SCRIPTS=1 so all installer-based builds (static, docker, source) ship scripts.d, and drop the now-redundant per-build flags. Also document the previously-undocumented --enable/--disable-plugin-scripts options. scripts.d is Go-based and the Go toolchain is already required; the existing toolchain gate disables it gracefully when Go is unavailable.
ilyam8
changed the title
Ferroin
approved these changes
Jun 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2883
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Enable the
scripts.dplugin by default for all installer-based builds (static, Docker, source) by settingENABLE_SCRIPTS=1innetdata-installer.sh, aligning them with DEB/RPM packages. Also document--enable-plugin-scripts/--disable-plugin-scripts; no new deps (Go is already required and gated).Written for commit 83faa42. Summary will update on new commits.