Skip to content

[NAE-1876] Process URI v2#196

Merged
machacjozef merged 18 commits into
release/6.4.0from
NAE-1876
Feb 8, 2024
Merged

[NAE-1876] Process URI v2#196
machacjozef merged 18 commits into
release/6.4.0from
NAE-1876

Conversation

@Retoocs

@Retoocs Retoocs commented May 4, 2023

Copy link
Copy Markdown
Contributor

Description

Refactored UriNode API. Create index for PetriNet. Refactor uriNodeId persisting of Case and PetriNet

Implements NAE-1876

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually tested and with unit tests

Test Configuration

Name Tested on
OS Linux Mint 21.1 Cinnamon
Runtime Java 11
Dependency Manager Maven 3.8.1
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @tuplle
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Retoocs added 11 commits April 26, 2023 11:31
- refactor identifier of UriNode
- refactor UriService.getOrCreate
- add and update tests for UriService
- refactor UriService
- update tests
- create new index for PetriNet
- make uriNodeId of Case and PetriNet persisted only in elastic
- refactor import process endpoint to consume active node id
- refactor PetriNetService.findAllByUriNodeId
- improve parameters in PetriNetService.importPetriNet
- update tests
- switch deprecated method usage
- rollback of changes in ActionDelegate
- rollback of changes
@Retoocs Retoocs added improvement A change that improves on an existing feature Large labels May 4, 2023
@Retoocs Retoocs requested review from mazarijuraj and tuplle May 4, 2023 13:35
@Retoocs Retoocs self-assigned this May 4, 2023
Retoocs added 4 commits May 5, 2023 09:17
# Conflicts:
#	src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java
#	src/main/java/com/netgrif/application/engine/petrinet/service/interfaces/IPetriNetService.java
- resolve conflicts
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/startup/ImportHelper.groovy
#	src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java
#	src/main/java/com/netgrif/application/engine/workflow/service/WorkflowService.java
- resolve conflicts
- fix test
@Retoocs Retoocs changed the base branch from release/6.3.0 to release/6.3.1 May 24, 2023 06:04
Retoocs added 2 commits May 25, 2023 10:08
# Conflicts:
#	src/test/groovy/com/netgrif/application/engine/petrinet/service/PetriNetServiceTest.groovy
- resolve merge conflict
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 536 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +436 -100
Percentile : 84.53%

Total files changed: 37

Change summary by file extension:
.groovy : +136 -25
.java : +296 -75
.properties : +4 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@mazarijuraj mazarijuraj changed the base branch from release/6.3.1 to release/6.4.0 May 25, 2023 09:31
@Retoocs Retoocs mentioned this pull request Jun 15, 2023
18 tasks
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 536 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +436 -100
Percentile : 84.53%

Total files changed: 37

Change summary by file extension:
.groovy : +136 -25
.java : +296 -75
.properties : +4 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@machacjozef machacjozef merged commit 8270902 into release/6.4.0 Feb 8, 2024
@machacjozef machacjozef deleted the NAE-1876 branch February 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra Large improvement A change that improves on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants