Skip to content

[NAE-1882] Filter folder process#210

Merged
machacjozef merged 50 commits into
release/6.4.0from
NAE-1882
Feb 8, 2024
Merged

[NAE-1882] Filter folder process#210
machacjozef merged 50 commits into
release/6.4.0from
NAE-1882

Conversation

@Retoocs

@Retoocs Retoocs commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Reworked double-drawer menu items. They're all represented as a process. Added API functions for these items

Implements NAE-1882

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

Depends on #196

How Has Been This Tested?

Manually and with unit tests

Test Configuration

Name Tested on
OS Linux Mint 21.1 Cinnamon
Runtime Java 11
Dependency Manager Maven 3.8.1
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj, @tuplle
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Retoocs added 30 commits May 5, 2023 14:39
- add preference_item.xml
- remove unnecessary stuff from org_group.xml
- refactor preference item process api
- update tests
- implement folder instance creation
- update test
- update preference_item.xml
- update ActionDelegate.getOrCreateFolderRecursive
- link menu items together as a tree
- implement preference item removal logic
- implement ActionDelegate.moveMenuitem
- fix ActionDelegate.findFolderCase
# Conflicts:
#	src/test/groovy/com/netgrif/application/engine/petrinet/service/PetriNetServiceTest.groovy
- add findUriNodeId in ElasticCaseService
- add populateUriNodeId in WorkflowService
- update MenuItemApiTest
- refactor ActionDelegate.moveMenuItem
- implement UriService.getUriSeparator
- update preference_item.xml
- update MenuItemApiTest
- update ActionDelegate.changeMenuItem
- fix ActionDelegate.getOrCreateFolder
- fix ActionDelegate.findFolderCase
- update MenuItemApiTest
- update MenuItemApiTest
- add API transitions in preference_item.xml
- add config datafields in preference_item.xml
- implement duplication of view
- update MenuItemApiTest
- fix ActionDelegate.duplicateViewItem
- implement ability to change filter in preference_item.xml
- add translation entries in preference_item.xml
- add new transition change_filter in preference_item.xml
- mark some functions as deprecated in ActionDelegate
- refactor preference_item.xml
- refactor api for preference_item.xml
- update tests
- add new config fields in preference_item.xml
- refactor settings layout
- implement configuration of additional task view filter
- update layout in preference_item.xml
- implement tab label configuration
- add field for delete menu configuration
- add fields for header configuration
- update header modes configuration
- refactor default headers configuration implementation
Retoocs added 9 commits May 31, 2023 11:05
- update case_banned_nets_in_creation
- add menu item identifier sanitization
- add sk translations
- fix item roles
- implement additional filter removal
- update task view settings behaviors
- add roleRefs
- add identifier sanitization when duplicating menu item
- implement multichoice destination uri selector
- fix moveMenuItem context error
- fix appendChildCaseId
- fix tests
- update move menu item UI
- update translations
@Retoocs Retoocs added improvement A change that improves on an existing feature Extra Large labels Jun 15, 2023
@Retoocs Retoocs requested review from mazarijuraj and tuplle June 15, 2023 07:15
@Retoocs Retoocs self-assigned this Jun 15, 2023
Retoocs and others added 2 commits July 3, 2023 13:49
# Conflicts:
#	src/test/groovy/com/netgrif/application/engine/petrinet/service/PetriNetServiceTest.groovy
- remove save call that could cause inconsistent state of menu item case
Comment thread src/main/resources/petriNets/engine-processes/filter.xml
Comment thread src/test/resources/petriNets/filter_api_test.xml
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 4246 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +3636 -610
Percentile : 100%

Total files changed: 81

Change summary by file extension:
.groovy : +843 -238
.java : +533 -111
.properties : +5 -0
.xml : +2255 -261

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@Retoocs Retoocs mentioned this pull request Jul 4, 2023
18 tasks
@dpulls

dpulls Bot commented Feb 8, 2024

Copy link
Copy Markdown

🎉 All dependencies have been resolved !

# Conflicts:
#	src/test/groovy/com/netgrif/application/engine/action/FilterApiTest.groovy
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 3322 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +2977 -345
Percentile : 100%

Total files changed: 19

Change summary by file extension:
.groovy : +665 -69
.java : +57 -15
.xml : +2255 -261

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@machacjozef machacjozef merged commit d901a1c into release/6.4.0 Feb 8, 2024
@machacjozef machacjozef deleted the NAE-1882 branch February 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra Large improvement A change that improves on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants