Skip to content

[NAE-2101] release 6.4.2#324

Merged
Kovy95 merged 3 commits intorelease/6.4.2from
NAE-2101
Apr 7, 2026
Merged

[NAE-2101] release 6.4.2#324
Kovy95 merged 3 commits intorelease/6.4.2from
NAE-2101

Conversation

@Kovy95
Copy link
Copy Markdown
Contributor

@Kovy95 Kovy95 commented Apr 4, 2026

Description

  • changes according the bug in release branch and some proposed fixes from coderabbit

Dependencies

Third party dependencies

Blocking Pull requests

<Depends on #(PR id)>/

How Has Been This Tested?

  • <Name of a test [test file](link to the test file)>

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc. You can use >

Name Tested on
OS LinuxMint 22
Runtime Node 20.18.0
Dependency Manager NPM 10.8.2
Framework version Angular 13.3
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • Bug Fixes

    • Upload flow no longer gets blocked by a prior task-data validation step, reducing unexpected upload rejections.
    • Button-related form validation now handles failed validations without affecting other field types.
    • Improved component teardown order and explicit unsubscription to prevent resource leaks.
  • Documentation

    • Updated Slovak translation for export error notifications.
  • Chores

    • Bumped components-core compatibility version.

Kovy95 added 2 commits April 4, 2026 12:54
- chanegs according the bug in release branch and some proposed fixes from coderabbit
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 77e1ea95-cfc7-4346-b942-3c846ccae639

📥 Commits

Reviewing files that changed from the base of the PR and between 85c598e and c8fd881.

📒 Files selected for processing (7)
  • projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.spec.ts
  • projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts
  • projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.spec.ts
  • projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts
  • projects/netgrif-components-core/src/lib/task/services/task-data.service.ts
  • projects/netgrif-components/src/lib/data-fields/file-field/file-default-field/file-default-field.component.ts
  • projects/netgrif-components/src/lib/data-fields/file-list-field/file-list-default-field/file-list-default-field.component.ts
💤 Files with no reviewable changes (2)
  • projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts
  • projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts

Walkthrough

Removed optional TaskContentService injections and pre-upload task-data validation gates from file upload components, adjusted TaskDataService field-update validation behavior, fixed a component teardown order/unsubscription, updated a Slovak translation string, and bumped a peer dependency version.

Changes

Cohort / File(s) Summary
File upload components
projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts, projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts, projects/netgrif-components/src/lib/data-fields/file-field/file-default-field/file-default-field.component.ts, projects/netgrif-components/src/lib/data-fields/file-list-field/file-list-default-field/file-list-default-field.component.ts
Removed optional TaskContentService constructor injections and removed pre-upload early-return validation that called validateTaskData(); constructors and super(...) calls updated accordingly.
Unit tests for file fields
projects/netgrif-components-core/src/lib/data-fields/file-field/.../abstract-file-default-field.component.spec.ts, projects/netgrif-components-core/src/lib/data-fields/file-list-field/.../abstract-file-list-default-field.component.spec.ts
Adjusted test helper components to drop optional TaskContentService constructor parameter and corresponding super(...) argument.
Task data update logic
projects/netgrif-components-core/src/lib/task/services/task-data.service.ts
Changed field-update handling: only ButtonField triggers the previous early-return path when validateData === 'true' and validateTaskData() fails; also sets field.changed = false before returning.
Component teardown
projects/netgrif-components/src/lib/navigation/group-navigation-component-resolver/default-components/default-tabbed-case-view/default-tabbed-case-view.component.ts
ngOnDestroy() now calls super.ngOnDestroy() first and explicitly unsubscribes _headersSub (if present) before completing loading$.
Localization
projects/netgrif-components-core/src/assets/i18n/sk.json
Updated Slovak translation for export.errorExportDownload from English to Slovak message.
Package peer dependency
projects/netgrif-components/package.json
Bumped peer dependency @netgrif/components-core from 6.4.2-rc.6 to 6.4.2.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'NAE-2101 release 6.4.2' clearly identifies a release version bump and maps to the target branch (release/6.4.2), which aligns with the primary change of updating the peer dependency version from 6.4.2-rc.6 to 6.4.2 and related bug fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 4, 2026
- reverting most of the task [NAE-2393] Validation property on set data event
- implement validation on setData only for button field
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@Kovy95 Kovy95 merged commit cb30dcc into release/6.4.2 Apr 7, 2026
10 of 11 checks passed
@Kovy95 Kovy95 deleted the NAE-2101 branch April 7, 2026 10:10
@coderabbitai coderabbitai Bot mentioned this pull request Apr 7, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant