Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/netgrif-components-core/src/assets/i18n/sk.json
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,6 @@
"pageAmount": "Strana {{page}} z {{amountPages}}"
},
"export": {
"errorExportDownload": "File failed to download!"
"errorExportDownload": "Stiahnutie súboru zlyhalo!"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,8 @@ class TestFileComponent extends AbstractFileDefaultFieldComponent {
translate: TranslateService,
sanitizer: DomSanitizer,
eventService: EventService,
@Optional() protected _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileField>) {
super(taskResourceService, log, snackbar, translate, eventService, sanitizer, _taskContentService, dataFieldPortalData);
super(taskResourceService, log, snackbar, translate, eventService, sanitizer, dataFieldPortalData);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {DATA_FIELD_PORTAL_DATA, DataFieldPortalData} from "../../models/data-fie
import {FILE_FIELD_HEIGHT, FILE_FIELD_PADDING, PREVIEW, PREVIEW_BUTTON} from '../models/file-field-constants';
import {FileFieldRequest} from "../../../resources/interface/file-field-request-body";
import {AbstractFileFieldDefaultComponent} from '../../models/abstract-file-field-default-component';
import {TaskContentService} from "../../../task-content/services/task-content.service";

export interface FileState {
progress: number;
Expand Down Expand Up @@ -107,7 +106,6 @@ export abstract class AbstractFileDefaultFieldComponent extends AbstractFileFiel
* @param _eventService used for parsing of backend response
* Option injected trough `NAE_INFORM_ABOUT_INVALID_DATA` InjectionToken
* @param _sanitizer Sanitize url of image preview
* @param _taskContentService for validating datafields on setData, optional dependency
* @param dataFieldPortalData Field and form control data if field is provided with portal
*/
protected constructor(protected _taskResourceService: TaskResourceService,
Expand All @@ -116,7 +114,6 @@ export abstract class AbstractFileDefaultFieldComponent extends AbstractFileFiel
protected _translate: TranslateService,
protected _eventService: EventService,
protected _sanitizer: DomSanitizer,
@Optional() protected _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileField>) {
super(_log, _snackbar, _translate, dataFieldPortalData);
this.state = this.defaultState;
Expand Down Expand Up @@ -213,9 +210,6 @@ export abstract class AbstractFileDefaultFieldComponent extends AbstractFileFiel
if (!this.checkAllowedTypes()) {
return;
}
if (this.dataField.component?.properties?.validateData === 'true' && this._taskContentService && !this._taskContentService.validateTaskData()) {
return;
}
this.state = this.defaultState;
this.state.uploading = true;
const fileFormData = new FormData();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {DATA_FIELD_PORTAL_DATA, DataFieldPortalData} from "../../models/data-fie
import {AbstractFileListDefaultFieldComponent} from "./abstract-file-list-default-field.component";
import {FormControl} from "@angular/forms";
import {WrappedBoolean} from "../../data-field-template/models/wrapped-boolean";
import {TaskContentService} from "../../../task-content/services/task-content.service";

describe('AbstractFileListDefaultFieldComponent', () => {
let component: TestFileListComponent;
Expand Down Expand Up @@ -102,9 +101,8 @@ class TestFileListComponent extends AbstractFileListDefaultFieldComponent {
snackbar: SnackBarService,
translate: TranslateService,
eventService: EventService,
@Optional() protected _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileListField>) {
super(taskResourceService, log, snackbar, translate, eventService, _taskContentService, dataFieldPortalData);
super(taskResourceService, log, snackbar, translate, eventService, dataFieldPortalData);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {take} from "rxjs/operators";
import {FileFieldValue} from "../../file-field/models/file-field-value";
import {FileFieldRequest} from "../../../resources/interface/file-field-request-body";
import {AbstractFileFieldDefaultComponent} from '../../models/abstract-file-field-default-component';
import {TaskContentService} from "../../../task-content/services/task-content.service";

export interface FilesState {
progress: number;
Expand Down Expand Up @@ -56,7 +55,6 @@ export abstract class AbstractFileListDefaultFieldComponent extends AbstractFile
protected _snackbar: SnackBarService,
protected _translate: TranslateService,
protected _eventService: EventService,
@Optional() protected _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileListField>) {
super(_log, _snackbar, _translate, dataFieldPortalData);
this.state = this.defaultState;
Expand Down Expand Up @@ -155,9 +153,6 @@ export abstract class AbstractFileListDefaultFieldComponent extends AbstractFile
if (!this.checkAllowedTypes()) {
return;
}
if (this.dataField.component?.properties?.validateData === 'true' && this._taskContentService && !this._taskContentService.validateTaskData()) {
return;
}

this.state = this.defaultState;
this.state.uploading = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {ChangedFieldsMap} from '../../event/services/interfaces/changed-fields-m
import {TaskFields} from '../../task-content/model/task-fields';
import {EnumerationField} from "../../data-fields/enumeration-field/models/enumeration-field";
import {FrontActionService} from "../../actions/services/front-action.service";
import {ButtonField} from "../../data-fields/button-field/models/button-field";

/**
* Handles the loading and updating of data fields and behaviour of
Expand Down Expand Up @@ -200,8 +201,9 @@ export class TaskDataService extends TaskHandlingService implements OnDestroy {
this._taskContentService.taskFieldsIndex[parentTaskId].fields[field.stringId] = field;
field.valueChanges().subscribe(() => {
if (this.wasFieldUpdated(field)) {
if (field.component?.properties?.validateData === 'true' && !this._taskContentService.validateTaskData()) {
if (field instanceof ButtonField && field.component?.properties?.validateData === 'true' && !this._taskContentService.validateTaskData()) {
field.waitingForResponse = false;
field.changed = false;
return;
}
if (field instanceof DynamicEnumerationField) {
Expand Down
2 changes: 1 addition & 1 deletion projects/netgrif-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"nae frontend"
],
"peerDependencies": {
"@netgrif/components-core": "6.4.2-rc.6",
"@netgrif/components-core": "6.4.2",
"@angular-material-components/datetime-picker": "~7.0.1",
"@angular-material-components/moment-adapter": "~7.0.0",
"@angular/animations": "~13.3.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import {
LoggerService,
SnackBarService,
TaskResourceService,
AbstractFileDefaultFieldComponent,
TaskContentService
AbstractFileDefaultFieldComponent
} from "@netgrif/components-core";
import {TranslateService} from "@ngx-translate/core";
import {DomSanitizer} from "@angular/platform-browser";
Expand All @@ -27,9 +26,8 @@ export class FileDefaultFieldComponent extends AbstractFileDefaultFieldComponent
eventService: EventService,
protected _sanitizer: DomSanitizer,
protected dialog: MatDialog,
@Optional() _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileField>) {
super(taskResourceService, log, snackbar, translate, eventService, _sanitizer, _taskContentService, dataFieldPortalData);
super(taskResourceService, log, snackbar, translate, eventService, _sanitizer, dataFieldPortalData);
}

public showPreviewDialog() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import {
EventService,
DATA_FIELD_PORTAL_DATA,
DataFieldPortalData,
FileListField, AbstractFileListDefaultFieldComponent,
TaskContentService
FileListField, AbstractFileListDefaultFieldComponent
} from '@netgrif/components-core'

@Component({
Expand All @@ -23,8 +22,7 @@ export class FileListDefaultFieldComponent extends AbstractFileListDefaultFieldC
snackbar: SnackBarService,
translate: TranslateService,
eventService: EventService,
@Optional() _taskContentService: TaskContentService,
@Optional() @Inject(DATA_FIELD_PORTAL_DATA) dataFieldPortalData: DataFieldPortalData<FileListField>) {
super(taskResourceService, log, snackbar, translate, eventService, _taskContentService, dataFieldPortalData);
super(taskResourceService, log, snackbar, translate, eventService, dataFieldPortalData);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ export class DefaultTabbedCaseViewComponent extends AbstractTabbedCaseViewCompon
}

ngOnDestroy(): void {
super.ngOnDestroy();
this._headersSub?.unsubscribe();
this.loading$.complete()
}
}
Loading