chore: remove plugins_break_builds_with_unsupported_plugin_versions feature flag #4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request adds or modifies JavaScript ( |
ericapisani
added
the
type: chore
nickytonline
approved these changes
Dec 16, 2022
Contributor
nickytonline
left a comment
nickytonline
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @ericapisani! 🧹
kodiakhq
bot
deleted the
ep/remove-plugins_break_builds_with_unsupported_plugin_versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/327
The feature that this was guarding has now been rolled out to everyone and can now be safely removed.
PR where this flag was initially added: https://github.com/netlify/build/pull/4672/files
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
