feat: serve bundled functions in ntl dev #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
eduardoboucas
commented
Apr 8, 2021
eduardoboucas
commented
Apr 8, 2021
erezrokah
suggested changes
Apr 8, 2021
Contributor
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Hi @eduardoboucas, this looks great pending one code comment.
What do you think about adding a test case for this?
It will be nice to test es6 modules and TypeScript functions as part of the CLI tests.
Member
Author
Thanks @erezrokah! I've addressed the comment and also added tests in 88f1f47. Let me know what you think! |
eduardoboucas
commented
Apr 8, 2021
erezrokah
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR uses
zip-it-and-ship-itto bundle functions before serving them withnetlify dev.- Test plan
⏳
- A picture of a cute animal (not mandatory but encouraged)