feat: use zisi function builder when using TypeScript functions #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
erezrokah
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Since #2094,
netlify devis serving functions after bundling them withzip-it-and-ship-it. To contain the risks of that change, we enable it only when we detect that users have opted in to esbuild via thefunctions.node_bundlerconfiguration property.However, we treat TypeScript support as GA, with no correlation with the opt-in mechanism to the beta feature that
node_bundlerprovides. This means that someone who wants to continue to use the legacy bundler for JavaScript functions but also include a TypeScript function will not be able to access the TypeScript function locally, since CLI will serve the raw file.This PR changes the condition used by the
zisifunction builder, so that it's enable ifnode_bundlerisesbuildor there's at least one TypeScript function in the functions directory.- Test plan
New test added.
- A picture of a cute animal (not mandatory but encouraged)