Skip to content

feat: prints functions proxy output #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Aug 13, 2021
Merged

feat: prints functions proxy output #3152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e6fd7
feat: prints functions proxy output
eduardoboucas Aug 12, 2021
5a2ebc8
Merge branch 'main' into feat/functions-proxy-output
kodiakhq[bot] Aug 12, 2021
c9c030a
chore: fix tests
eduardoboucas Aug 12, 2021
dcea08e
Merge branch 'main' into feat/functions-proxy-output
kodiakhq[bot] Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/functions/local-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
const { stdout } = require('process')

const { getBinaryPath: getFunctionsProxyPath } = require('@netlify/local-functions-proxy')

const execa = require('../../utils/execa')
Expand Down Expand Up @@ -34,8 +36,11 @@ const runFunctionsProxy = ({ binaryPath, context, directory, event, name, timeou
'--timeout',
`${timeout}s`,
]
const proxyProcess = execa(functionsProxyPath, parameters)

proxyProcess.stderr.pipe(stdout)
Comment thread
eduardoboucas marked this conversation as resolved.

return execa(functionsProxyPath, parameters)
return proxyProcess
}

module.exports = { runFunctionsProxy }
7 changes: 6 additions & 1 deletion tests/serving-functions-go.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ test('Updates a Go function when a file is modified', async (t) => {

let proxyCallCount = 0

module.exports = async (...args) => {
const handler = (...args) => {
if (args[0] === 'go') {
const binaryPath = args[1][2]

Expand All @@ -45,6 +45,11 @@ test('Updates a Go function when a file is modified', async (t) => {
}
}
}

module.exports = (...args) => ({
...handler(...args) || {},
stderr: { pipe: () => {} }
})
`)

await withSiteBuilder('go-function-update', async (builder) => {
Expand Down
7 changes: 6 additions & 1 deletion tests/serving-functions-rust.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ test('Updates a Rust function when a file is modified', async (t) => {
const [execaMock, removeExecaMock] = await createExecaMock(`
let proxyCallCount = 0

module.exports = async (...args) => {
const handler = (...args) => {
if (args[0] === 'cargo') {
return {
stderr: '',
Expand All @@ -61,6 +61,11 @@ test('Updates a Rust function when a file is modified', async (t) => {
}
}
}

module.exports = (...args) => ({
...handler(...args) || {},
stderr: { pipe: () => {} }
})
`)

await withDevServer(
Expand Down