Skip to content

feat: add a prompt to modify users .gitignore (closes netlify#2038) #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2021
Merged

feat: add a prompt to modify users .gitignore (closes netlify#2038) #3595

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45b4cb0
feat: add a prompt to modify users .gitignore (closes netlify#2038)
Nov 5, 2021
ac2453a
Merge branch 'main' into feat/gitignore-prompt
ngonsoto Nov 8, 2021
b943743
Merge branch 'main' into feat/gitignore-prompt
ngonsoto Nov 10, 2021
46c9842
Merge branch 'main' into feat/gitignore-prompt
Dec 7, 2021
7ea5b3f
feat: add a log message when modifies .gitignore file (closes netlify…
Dec 7, 2021
7414fa7
Merge branch 'main' into feat/gitignore-prompt
kodiakhq[bot] Dec 10, 2021
3b677fb
Merge branch 'main' into feat/gitignore-prompt
Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/utils/gitignore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const parseIgnore = require('parse-gitignore')

const { fileExistsAsync, readFileAsync, writeFileAsync } = require('../lib/fs')

const { log } = require('./command-helpers')

const hasGitIgnore = async function (dir) {
const gitIgnorePath = path.join(dir, '.gitignore')
const hasIgnore = await fileExistsAsync(gitIgnorePath)
Expand All @@ -30,6 +32,8 @@ const ensureNetlifyIgnore = async function (dir) {
}
/* Not ignoring .netlify folder. Add to .gitignore */
if (!ignorePatterns || !ignorePatterns.patterns.some((pattern) => /(^|\/|\\)\.netlify($|\/|\\)/.test(pattern))) {
log()
log('Adding local .netlify folder to .gitignore file...')
Copy link
Contributor

@lukasholzer lukasholzer Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log('Adding local .netlify folder to .gitignore file...')
log('Adding local .netlify folder to .gitignore file.')

const newContents = `${gitIgnoreContents}\n${ignoreContent}`
await writeFileAsync(gitIgnorePath, newContents, 'utf8')
}
Expand Down