Skip to content

Conversation

@jasonbarry
Copy link
Contributor

@jasonbarry jasonbarry commented Oct 27, 2022

Summary

Fixes this prod test, which I believe to have been broken due to this open-api change.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@jasonbarry jasonbarry self-assigned this Oct 27, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

📊 Benchmark results

Comparing with a9acd6f

Package size: 241 MB

(no change)

^  241 MB  241 MB 
│   ┌──┐    ┌──┐  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
└───┴──┴────┴──┴──>
    T-1      T    
Legend
  • T-1 (a9acd6f): 241 MB
  • T (current commit): 241 MB

@jasonbarry jasonbarry requested a review from danez October 27, 2022 19:35
@jasonbarry jasonbarry marked this pull request as ready for review October 27, 2022 19:35
@jasonbarry jasonbarry added the automerge Add to Kodiak auto merge queue label Oct 27, 2022
@kodiakhq kodiakhq bot merged commit 423be8f into main Oct 27, 2022
@kodiakhq kodiakhq bot deleted the fix/fix-underscore-in-broken-test branch October 27, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants