Skip to content

Conversation

@pvorozhe
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes pillar-workflow/191 (1/2)


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@pvorozhe pvorozhe requested a review from a team as a code owner October 27, 2022 20:49
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

📊 Benchmark results

Comparing with 0415efe

Package size: 247 MB

(no change)

^                  245 MB  241 MB  241 MB  241 MB  247 MB  247 MB  247 MB 
│  241 MB  241 MB   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

package.json Outdated
"husky": "^8.0.0",
"ini": "^2.0.0",
"mock-fs": "^5.1.2",
"netlify-cli": "^12.0.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have the CLI as dependency in the CLI :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :my-bad:

@akahn akahn requested a review from danez October 28, 2022 15:52
akahn
akahn previously approved these changes Oct 28, 2022
Copy link
Contributor

@codebyuma codebyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy update looks good to me 🎉

Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file npm-shrinkwrap.json still has changes, could you revert those?

@pvorozhe
Copy link
Contributor Author

@danez a bit of git fumbling later, done. sorry bout that!

@pvorozhe pvorozhe merged commit 1ab07f0 into main Oct 31, 2022
@pvorozhe pvorozhe deleted the pvorozhe/sm-beta-language-remove branch October 31, 2022 16:56
@Skn0tt
Copy link
Contributor

Skn0tt commented Nov 2, 2022

this PR is failing on main, due to a snapshot not being updated: https://github.com/netlify/cli/actions/runs/3378626827/jobs/5609083160#step:11:136. I wonder why the CI here didn't catch it 🤔

I'll fix this as part of #5200, but we should ensure that our CI catches these kinds of things in the future.

Skn0tt added a commit that referenced this pull request Nov 2, 2022
@Skn0tt
Copy link
Contributor

Skn0tt commented Nov 2, 2022

I have a hunch that the chore: update contributors field commits are resulting in green runs, because the test:affected strategy is resulting in untouched files not being tested. Maybe we could adapt the test:affected strategy to not only test files touched by recent commits, but files touched in HEAD..PR HEAD

@Skn0tt
Copy link
Contributor

Skn0tt commented Nov 2, 2022

@lukasholzer maybe you have an idea

Skn0tt added a commit that referenced this pull request Nov 4, 2022
* feat: add mode for streamed responses

* chore: update contributors field

* chore: update contributors field

* fix: prettier

* chore: update contributors field

* chore: update contributors field

* Update src/utils/proxy.cjs

Co-authored-by: Kunal Kundu <kunal99kundu@gmail.com>

* chore: update contributors field

* chore: update contributors field

* fix: write test to ensure edge functions can be streamed

* chore: update contributors field

* fix: remove .only

* chore: update contributors field

* chore: update contributors field

* chore: update contributors field

* fix: snapshots (see #5194 (comment))

* chore: update contributors field

* chore: update contributors field

* fix: windows doesn't like overriding sites

* chore: update contributors field

* chore: update contributors field

Co-authored-by: Skn0tt <Skn0tt@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Co-authored-by: Kunal Kundu <kunal99kundu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants