-
Notifications
You must be signed in to change notification settings - Fork 434
chore: remove beta tags from CLI and docs #5194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Benchmark resultsComparing with 0415efe Package size: 247 MB(no change) |
package.json
Outdated
| "husky": "^8.0.0", | ||
| "ini": "^2.0.0", | ||
| "mock-fs": "^5.1.2", | ||
| "netlify-cli": "^12.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have the CLI as dependency in the CLI :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch :my-bad:
codebyuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy update looks good to me 🎉
danez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file npm-shrinkwrap.json still has changes, could you revert those?
…/netlify/cli into pvorozhe/sm-beta-language-remove
…/netlify/cli into pvorozhe/sm-beta-language-remove
|
@danez a bit of git fumbling later, done. sorry bout that! |
|
this PR is failing on main, due to a snapshot not being updated: https://github.com/netlify/cli/actions/runs/3378626827/jobs/5609083160#step:11:136. I wonder why the CI here didn't catch it 🤔 I'll fix this as part of #5200, but we should ensure that our CI catches these kinds of things in the future. |
|
I have a hunch that the |
|
@lukasholzer maybe you have an idea |
* feat: add mode for streamed responses * chore: update contributors field * chore: update contributors field * fix: prettier * chore: update contributors field * chore: update contributors field * Update src/utils/proxy.cjs Co-authored-by: Kunal Kundu <kunal99kundu@gmail.com> * chore: update contributors field * chore: update contributors field * fix: write test to ensure edge functions can be streamed * chore: update contributors field * fix: remove .only * chore: update contributors field * chore: update contributors field * chore: update contributors field * fix: snapshots (see #5194 (comment)) * chore: update contributors field * chore: update contributors field * fix: windows doesn't like overriding sites * chore: update contributors field * chore: update contributors field Co-authored-by: Skn0tt <Skn0tt@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> Co-authored-by: Kunal Kundu <kunal99kundu@gmail.com>
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes pillar-workflow/191 (1/2)
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)