Skip to content

fix: ensure HMR requests can be streamed #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 4, 2022
Merged

fix: ensure HMR requests can be streamed #5200

merged 22 commits into from
Nov 4, 2022

Conversation

@Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 2, 2022 •
edited
Loading

addresses #4569

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 2, 2022
@Skn0tt Skn0tt changed the title fix: add streaming mode for requests without etag generation fix: ensure HMR requests can be streamed Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

📊 Benchmark results

Comparing with 1ab07f0

Package size: 247 MB

⬆️ 0.00% increase vs. 1ab07f0

^                  245 MB  241 MB  241 MB  241 MB  247 MB  247 MB  247 MB  247 MB 
│  241 MB  241 MB   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend

tinfoil-knight
tinfoil-knight reviewed Nov 2, 2022
View reviewed changes
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 2, 2022

tested this locally with a fresh Nuxt app. can confirm that HMR is broken on main, but works with this change.

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 2, 2022

the test I added fails on main. so while it doesn't test HMR in particular, it should still ensure we don't break streaming responses in the future.

@Skn0tt Skn0tt marked this pull request as ready for review November 2, 2022 14:56
eduardoboucas
eduardoboucas previously approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Skn0tt Skn0tt mentioned this pull request Nov 2, 2022
Merged
5 tasks
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 2, 2022 •
edited
Loading

@eduardoboucas thanks for the review! could I get another ✅? had to update a snapshot (see #5194 (comment)).

eduardoboucas
eduardoboucas previously approved these changes Nov 2, 2022
View reviewed changes
@malcolmmurdock
Copy link

malcolmmurdock commented Nov 3, 2022

Can confirm the change to proxy.cjs fixes hot reload for netlify dev in our Nuxt 2 app.

@Skn0tt Skn0tt merged commit 9741537 into main Nov 4, 2022
@Skn0tt Skn0tt deleted the fix-4569 branch November 4, 2022 09:58
@token-generator-app token-generator-app bot mentioned this pull request Nov 4, 2022
Merged
This was referenced Nov 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

+1 more reviewer

@tinfoil-knight tinfoil-knight tinfoil-knight left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: bug code to address defects in shipped code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Skn0tt @malcolmmurdock @eduardoboucas @tinfoil-knight