build: slim down npm tasks and make them more consistent #7152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable changes here: - Make testing targets more consistent. E.g. no more `npm run e2e`, - Slim down how many tasks we have, including by getting rid of `test:ci` tasks. We already pass additional flags to Vitest in several CI workflows, so I don't see the benefit in maintaining these tasks. - Don't automatically run `test:init`. We already manually run it in the integration CI workflow, so I'm following that workflow's lead. (Hopefully) soon we'll incorporate these setup steps into the tests themselves so you don't have to run any pre-test setup steps at all. - Remove the explicit Vitest reporter. (This will make Vitest automatically use the GitHub Actions reporter in CI.)
📊 Benchmark resultsComparing with df222eb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes here:
npm run e2e,test:citasks. We already pass additional flags to Vitest in several CI workflows, so I don't see the benefit in maintaining these tasks.test:init. We already manually run it in the integration CI workflow, so I'm following that workflow's lead. (Hopefully) soon we'll incorporate these setup steps into the tests themselves so you don't have to run any pre-test setup steps at all.