fix(npm-shrinkwrap.json): re-remove dev deps #7161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 90afd98
|
serhalp
commented
Apr 1, 2025
ndhoule
force-pushed
the
fix/no-dev-deps-in-shrinkwrap
branch
from
46f2064 to
22c57c4
Compare
We accidentally reintroduced dev dependencies in the `npm-shrinkwrap.json` file here: https://github.com/netlify/cli/pull/7119/files?file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.md&file-filters%5B%5D=.yml&show-viewed-files=true&show-deleted-files=false#diff-3d80e6f9eb8af7a28cbe2209d086150e29b68f860376ee618a0041ca9b5c786dL18-L49. The deleted script was deleting `package.json#devDependencies` before running `npm i && npm shrinkwrap`, which resulted in the shrinkwrap being built from a modified `package-lock.json` with dev deps removed 😓.
ndhoule
force-pushed
the
fix/no-dev-deps-in-shrinkwrap
branch
from
22c57c4 to
29de735
Compare
serhalp
commented
Apr 1, 2025
Member
Author
serhalp
left a comment
serhalp
left a comment
There was a problem hiding this comment.
LGTM (can't review because I originally opened it)
| "test:unit": "vitest run tests/unit/", | ||
| "postinstall": "node ./scripts/postinstall.js", | ||
| "prepublishOnly": "npm shrinkwrap", | ||
| "prepublishOnly": "node ./scripts/prepublishOnly.js", |
ndhoule
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We accidentally reintroduced dev dependencies in the
npm-shrinkwrap.jsonfile here: https://github.com/netlify/cli/pull/7119/files?file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.md&file-filters%5B%5D=.yml&show-viewed-files=true&show-deleted-files=false#diff-3d80e6f9eb8af7a28cbe2209d086150e29b68f860376ee618a0041ca9b5c786dL18-L49.The deleted script was deleting
package.json#devDependenciesbefore runningnpm i && npm shrinkwrap, which resulted in the shrinkwrap being built from a modifiedpackage-lock.jsonwith dev deps removed 😓.cc @ndhoule