Skip to content

Dev: Dont crash on no config file#820

Merged
RaeesBhatti merged 1 commit into
raees/windows-path-space-problem-fixfrom
raees/no-config-crash-fix
Apr 13, 2020
Merged

Dev: Dont crash on no config file#820
RaeesBhatti merged 1 commit into
raees/windows-path-space-problem-fixfrom
raees/no-config-crash-fix

Conversation

@RaeesBhatti
Copy link
Copy Markdown
Contributor

- Summary
Fixes: #819

- Test plan

  • Create new create-react-app project
  • Run netlify dev

- Description for the changelog
Check for configPath variable before trying to resolve it and parse config.

- A picture of a cute animal (not mandatory but encouraged)
🐶

@RaeesBhatti RaeesBhatti requested a review from ehmicky April 13, 2020 12:38
@RaeesBhatti RaeesBhatti merged commit 647aee8 into raees/windows-path-space-problem-fix Apr 13, 2020
RaeesBhatti added a commit that referenced this pull request Apr 13, 2020
RaeesBhatti added a commit that referenced this pull request Apr 13, 2020
RaeesBhatti added a commit that referenced this pull request Apr 13, 2020
* Dev: Quote command binary path to make it space safe

* Dev: Improve app process spawning

* Dev: Ignore error on app process kill

* Tests: Dont use shell

* Comment

* Dev: Dont crash on no config file (#820)

* Revert "Dev: Dont crash on no config file (#820)" (#821)

This reverts commit 647aee8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants