PR'ing achievement UI into the feature branch#485
Merged
kenny-io merged 5 commits intofeature/rewardsfrom Mar 8, 2021
Merged
Conversation
Contributor
kenny-io
commented
Mar 5, 2021
kenny-io
commented
philhawksworth
approved these changes
Mar 8, 2021
Contributor
philhawksworth
left a comment
philhawksworth
left a comment
There was a problem hiding this comment.
Looking good @kenny-io !
Not blocking for right now, but we should probably take out some of the logging before this feature branch gets merged to main.
bencodezen
pushed a commit
that referenced
this pull request
Mar 15, 2021
* WIP: added achievement notif * Remove comments * Achievement UI Spike * user achievement flow ok * Achievement Spike New UI
bencodezen
added a commit
that referenced
this pull request
Mar 22, 2021
* feature (#457): scaffold price rule post request * docs (#457): add task for authentication * PR'ing achievement UI into the feature branch (#485) * WIP: added achievement notif * Remove comments * Achievement UI Spike * user achievement flow ok * Achievement Spike New UI * Clean up the logs * feature: allows us to programmatically create a price rule with graphql api * feature: add discount code with removal of old code * feature (#472): add check reward function (#488) * feature: add check that change is called * config: update package lock * feature: log more detailed event * feature: define achievement * feature (#472): add check reward function * fix (#472): variable typo * feature (#472): add better messages * docs (#472): provide code comments * feature (#457): scaffold price rule post request * docs (#457): add task for authentication * feature: allows us to programmatically create a price rule with graphql api * feature: add discount code with removal of old code * feature: add test out event payload * feature: add discount code * docs: add notes * config: update package lock * refactor: consolidate discount code into one serverless function * fix: authentication with shopify * feature: add dynamic code and date * fix: re-enable dynamic event data * feature: add discount code to reward table * feature: customize price rule with achievement id * feature: add error state if shopify reward creation fails * refactor: add try catch to improve code thanks to Sarah Co-authored-by: Ekene Eze <ekeneeze3@gmail.com>
kenny-io
added a commit
that referenced
this pull request
Apr 9, 2021
* PR'ing achievement UI into the feature branch (#485) * WIP: added achievement notif * Remove comments * Achievement UI Spike * user achievement flow ok * Achievement Spike New UI * Clean up the logs * added rewards code ui * chore: fix link colors
kenny-io
added a commit
that referenced
this pull request
Apr 21, 2021
* PR'ing achievement UI into the feature branch (#485) * WIP: added achievement notif * Remove comments * Achievement UI Spike * user achievement flow ok * Achievement Spike New UI * Clean up the logs * more updates * re formatting * update sticker link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.