Merged
Conversation
* WIP: added achievement notif * Remove comments * Achievement UI Spike * user achievement flow ok * Achievement Spike New UI
Contributor
|
Awesome, @kenny-io ! One think I think we should adjust, is the colour of the link text in that body copy. The contrast is pretty low and I find it hard to see. Is there another colour in our palette that might give better contrast there? I originally suggested black for those links in order to get good contrast but not introduce another colour to the palette. But perhaps there is something else which suits? |
Contributor
Author
|
@philhawksworth Updated Links as requested
|
philhawksworth
approved these changes
Apr 8, 2021
Contributor
philhawksworth
left a comment
philhawksworth
left a comment
There was a problem hiding this comment.
Looking good @kenny-io! Let's merge this sukka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the UI to show the reward codes