Skip to content

fix: remove upload debug log line#623

Merged
mrstork merged 1 commit into
masterfrom
upload-debug-loggin
Feb 23, 2026
Merged

fix: remove upload debug log line#623
mrstork merged 1 commit into
masterfrom
upload-debug-loggin

Conversation

@mrstork

@mrstork mrstork commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

These two log lines print out an excessive amount of times per deploy/build and I don't think they produce very meaningful/useful information.

I propose we remove it and stick to just logging on upload errors.

@mrstork
mrstork requested a review from a team as a code owner February 23, 2026 22:25
@netlify

netlify Bot commented Feb 23, 2026

Copy link
Copy Markdown

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 9b16adc
🔍 Latest deploy log https://app.netlify.com/projects/open-api/deploys/699cd3c976545400080a9425
😎 Deploy Preview https://deploy-preview-623--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Feb 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7b5a9 and 9b16adc.

📒 Files selected for processing (1)
  • go/porcelain/deploy.go
💤 Files with no reviewable changes (1)
  • go/porcelain/deploy.go

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed verbose logging statements during file upload operations to reduce log output verbosity.

Walkthrough

This patch removes two logging statements from the file upload flow in go/porcelain/deploy.go. A verbose debug log that prints deploy_id, file_path, file_sum, and file_size when starting a file upload is removed, along with an Info log that announces the specific file being uploaded within the retry loop. No control flow, error handling, or functional behavior is altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: remove upload debug log line' clearly and concisely summarizes the main change—removing a debug log statement from the upload flow.
Description check ✅ Passed The description explains why the logs are being removed (excessive output, not meaningful) and the proposed solution, which directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upload-debug-loggin

Comment @coderabbitai help to get the list of available commands and usage tips.

@mrstork
mrstork merged commit 3284b41 into master Feb 23, 2026
15 checks passed
@mrstork
mrstork deleted the upload-debug-loggin branch February 23, 2026 22:38
mrstork pushed a commit that referenced this pull request Feb 23, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.49.2](v2.49.1...v2.49.2)
(2026-02-23)


### Bug Fixes

* remove upload debug log line
([#623](#623))
([3284b41](3284b41))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants