fix: remove upload debug log line#623
Conversation
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis patch removes two logging statements from the file upload flow in go/porcelain/deploy.go. A verbose debug log that prints deploy_id, file_path, file_sum, and file_size when starting a file upload is removed, along with an Info log that announces the specific file being uploaded within the retry loop. No control flow, error handling, or functional behavior is altered. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
🤖 I have created a release *beep* *boop* --- ## [2.49.2](v2.49.1...v2.49.2) (2026-02-23) ### Bug Fixes * remove upload debug log line ([#623](#623)) ([3284b41](3284b41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
These two log lines print out an excessive amount of times per deploy/build and I don't think they produce very meaningful/useful information.
I propose we remove it and stick to just logging on upload errors.