-
Notifications
You must be signed in to change notification settings - Fork 67
feat: plugin synchronization from repository to CMS #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ly set up for TypeScript
6ddf767 to
a01a086
Compare
b90474e to
4c6a0cf
Compare
03f279b to
0526301
Compare
|
So this is in a good state @hexagoncircle @estephinson. Since https://github.com/netlify/marketing-cms/pull/196 was merged, the compatibility field updates properly now. We can discuss this tomorrow but this is probably what we want to do:
Monitor what happens the next time one of our repos puts up a PR for plugins.json changes, e.g. Next Runtime |
| | { | ||
| version: string | ||
| migrationGuide: strings | ||
| migrationGuide: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch ha!
| pull_request: | ||
| types: | ||
| - closed | ||
| jobs: | ||
| sync-to-cms: | ||
| # Only run if the merged PR wasn't an automated PR for synching from the cms to the repo | ||
| if: github.event.pull_request.merged && !contains(github.event.pull_request.labels.*.name, 'cms_sync') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estephinson @tzmanics, this is the guard to prevent a potential infinite loop of sync repo to cms/cms to repo I mentioned. Ed or whoever will need to reapprove the PR.
Thanks for contributing the Netlify plugins directory!
Are you adding a plugin or updating one?
No plugin is being added or updated. A GitHub action has been added that will synchronize plugins from the repository to our CMS for the Integrations Hub.
Have you completed the following?
Related documents and issues
https://github.com/netlify/pod-ecosystem-frameworks/issues/223
Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.
Currently the new GitHub action will only run when the branch associated with this PR is changed. This is expected for the time being while things are being tested.
gh co 820npm installto ensure you have the new packages added in this PR..envfile (it's in the gitignore 😅 ), and add the following keys:GITHUB_WORKSPACEkey or pass it in (pwdif you're in the root of the plugins project) e.g.GITHUB_WORKSPACE=$(pwd) NODE_ENV=development npx tsx bin/sync_plugins_to_cms.js.Note that it will log
running in development modewhen in development mode only. This is to indicate that environment variables are being loaded via dotenv. When running in the GitHub Actions environment, environment secrets will be used.Currently, a
Sandboxenvironment is being used. To enable it for production:.github/workflows/sync-to-cms.ymland remove
since we only want the GitHub action running when PRs are merged to main.