feat(lobby): mark the real last-played game on the lobby#58
Merged
Conversation
Add a LobbyViewModel that reads the most recent round from the Room game_round ledger and expose its game as lastPlayedGame. The lobby maps it onto the games grid so the actual last-played game carries the LAST PLAYED badge (the card design already existed), replacing the static preview default; no rounds yet means no card is marked. Covered by LobbyViewModelTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the lobby's existing LAST PLAYED card design to real data: the badge now sits on the game the user actually played last, instead of the static preview default.
Rationale
The
GameCardalready renders the LAST PLAYED badge + highlight from aisLastPlayedflag; it was just driven by static preview data (pinned to Crash). The newLobbyViewModelreads the Room-backedgame_roundledger (newest first) and exposes the most recent round's game; the lobby nav entry maps it onto the games grid (isLastPlayed = card.key == lastPlayed). No round played yet -> no card marked.Verification
./gradlew testDebugUnitTest detekt ktlintCheck assembleDebug compileDebugAndroidTestKotlingreen locally (JDK 17).LobbyViewModelTest(last played is the most recent round's game; null with no rounds).Test plan
Checklist
feat/,fix/,chore/, etc.).[Unreleased].