docs(go-mutation-testing): describe what gremlins actually does on a build failure - #316
Merged
Merged
Conversation
…build failure The comment claimed the score is computed over the packages that still built. It is not: gremlins stops without printing "Test efficacy" at all, the extraction falls back to 0, and the job publishes 0% while passing. Confirmed against ldap-manager's runs — the broken ones have no efficacy line, the fixed one reports 57.07%. The check itself is unchanged and was already correct; only its explanation was wrong. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment-only correction to #314.
That PR's comment says a package gremlins cannot build is "left out of the score, so the job publishes a number computed over a subset". That is not what happens, and I wrote it without checking. gremlins stops without printing
Test efficacyat all, so the extraction falls back to0and the job publishes 0% while passing — a run that never happened, presented as a measurement.Confirmed against ldap-manager: the broken runs contain no efficacy line anywhere in the log, and the run after the fix reports
Test efficacy: 57.07%.The check itself is unchanged and was already doing the right thing; only the explanation of why it exists was wrong, and that explanation is what a future reader will rely on.