Skip to content

chore: capture reconcile design as ADR-010 and remove working specs#127

Merged
CybotTM merged 2 commits into
mainfrom
chore/spec-cleanup-adr-010
Jul 23, 2026
Merged

chore: capture reconcile design as ADR-010 and remove working specs#127
CybotTM merged 2 commits into
mainfrom
chore/spec-cleanup-adr-010

Conversation

@CybotTM

@CybotTM CybotTM commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

The /pr-finish spec-cleanup guard flagged two intermediate planning artifacts committed on main (docs/superpowers/specs/). Per the cleanup policy — convert durable decisions to an ADR, then remove the raw files — in two commits:

1. docs(adr): ADR-010 — Reconcile Engine as Single Source of Truth (capture)

  • Records the durable decisions from the 2026-07-08 reconcile/upgrade discoverability design, previously living only in code comments and Makefile help strings: the audit.py --reconcile [--all] [--apply] [--yes] JSON entrypoint as the only seam between cli_audit/reconcile.py and shell surfaces; the confirm-each + dry-run safety model (FORCE=1/--yes bypass prompts, never SYSTEM_TOOL_SAFELIST); the pin/lock override warning on upgrade-managed/upgrade-all; advisory-only discoverability hints.
  • Adds ADR-009 and ADR-010 to the docs/adr/README.md index (ADR-009 was missing from it).

2. chore: remove both spec files (recoverable from git history)

  • 2026-07-08 reconcile design → now captured in ADR-010.
  • 2026-07-22 blesh/bash-completion design → all durable content already lives in scripts/AGENTS.md (framework schema + invariants), catalog/COVERAGE.md (sweep results + exclusion rationale), root AGENTS.md (make targets), catalog/blesh.json, and scripts/install_blesh.sh header comments; no ADR warranted.

Nothing in tests, workflows, or other docs references docs/superpowers/ (grepped).

Verification

  • spec-cleanup-guard: clean (exit 0) on the branch
  • 740 passed, 1 skipped

Out of scope (noted for follow-up)

Doc drift found during analysis: blesh is absent from the tool lists in catalog/CATALOG_SUMMARY.md and the top list in catalog/COVERAGE.md; cli_audit/AGENTS.md still says "79 JSON files in catalog/" (now 100); ADR-009 still lacks the status note that aggressive reconcile is user-reachable.

CybotTM added 2 commits July 23, 2026 11:05
Captures the durable decisions from the 2026-07-08 reconcile/upgrade
discoverability design before its working spec is removed: the
audit.py --reconcile JSON entrypoint as the only seam between the Python
engine and shell surfaces, the confirm-each + dry-run safety model with
an unbypassable SYSTEM_TOOL_SAFELIST, the pin/lock override warning on
upgrade-managed/upgrade-all, and advisory-only discoverability hints.

Also indexes ADR-009 in docs/adr/README.md, which was missing from the
index table.

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
The 2026-07-08 reconcile/upgrade discoverability design is captured in
ADR-010; the 2026-07-22 blesh/bash-completion design's durable content
already lives in scripts/AGENTS.md (completion framework schema and
invariants), catalog/COVERAGE.md (sweep results and exclusion
rationale), root AGENTS.md (make targets), catalog/blesh.json, and
scripts/install_blesh.sh header comments. Both files remain recoverable
from git history.

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Copilot AI review requested due to automatic review settings July 23, 2026 09:07
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

@CybotTM
CybotTM merged commit 6007d08 into main Jul 23, 2026
24 of 25 checks passed
@CybotTM
CybotTM deleted the chore/spec-cleanup-adr-010 branch July 23, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants