docs(data-tools): point to cli-tools' modern-tools table, drop redundant copy#23
Conversation
…ant copy Per skill-repo-skill skills/skill-repo/references/skill-quality.md "Content value rubric" (Fact and trigger ownership): the standalone "Tool Selection" table restated the same Format->Tool mapping already implied by the "Key Patterns" section headers directly below it, and duplicated cli-tools-skill's canonical Legacy/Modern table for the grep/sed/awk-on-structured-data rows. Removed the table, folded its two non-redundant notes (dasel is the only native TOML tool; xmlstarlet as the XPath alternative for XML) into the dasel Key Pattern heading, and added a pointer to cli-tools-skill's table for the general legacy->modern comparison. The "no grep/sed/awk on structured formats" Critical Rule and the jq-no-in-place / mlr -I in-place gotchas in Key Patterns are untouched (inference-suppression, protected). Part of netresearch/skill-repo-skill#157. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the skills/data-tools/SKILL.md file by removing the redundant 'Tool Selection' table and referencing the modern tools table in the cli-tools skill instead. It also adds a note about using gh --jq with the GitHub CLI and expands the dasel header. The review feedback suggests using a relative link instead of an absolute URL to reference the cli-tools markdown file, as they reside in the same repository.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- docs(data-tools): point to cli-tools' modern-tools table, drop redundant copy (#23) - bump plugin.json and SKILL.md metadata.version to 1.6.3
Part of netresearch/skill-repo-skill#157 (A23 sweep) — ticks the
cli-tools / data-tools / file-searchcheckbox for this repo.Rubric
Per
skill-repo-skillskills/skill-repo/references/skill-quality.md § "Content value rubric", specifically the "Fact and trigger ownership" corollary: each fact has one canonical owning skill; siblings link instead of restating.What was cut, and why
SKILL.md's standalone## Tool Selectiontable (Format | Tool | Notes) was doubly redundant:## Key Patternssection directly below it already headers each tool by format (### jq -- JSON (no in-place),### yq -- YAML (in-place -i),### mlr -- JSONL / multi-format / DSL (in-place -I), ...), so the Format->Tool mapping was stated twice in the same SKILL.md.cli-tools-skill's canonical## Preferred Modern Toolstable (grep on JSON->jq,sed on YAML->yq,awk on CSV->qsv,sed on TOML->dasel).Removed the table. This is a judgment call, not a literal read of "replace the table with a pointer" — a bare deletion would have lost two facts that exist nowhere else in the file (dasel is the only native TOML tool;
xmlstarletis the XPath alternative for XML). Folded both into thedaselKey Pattern heading instead of dropping them, and added a one-line pointer to cli-tools-skill's table for the general legacy->modern framing. Net effect: no information lost, no table duplicated.What was kept, and why (protected)
grep,sed,awk, or inline interpreters... on JSON, JSONL, YAML, TOML, XML, or CSV") — untouched. Inference-suppression, hard-protected by the task.### jq -- JSON (no in-place)) and mlr -I for in-place (### mlr -- JSONL / multi-format / DSL (in-place -I)) gotchas — untouched, in## Key Patterns.jq-cookbook.md,yq-cookbook.md,dasel-cookbook.md,mlr-cookbook.md,csv-processing.md) — untouched; out of scope for this consolidation PR (data-tools remains the canonical owner of jq/yq/mlr/dasel/qsv transformation depth).## Anti-Patterns(BAD grep/sed/awk/python3-inline -> GOOD jq/yq/qsv) — kept; reinforces the Critical Rule with concrete failure examples (category 5, inference suppression, protected even though it reads as prose per the rubric's explicit protection).Verification
Do not merge — leaving for maintainer review per the sweep process.