chore(deps): stop dependabot proposing typescript >= 6.1 - #658
Merged
Conversation
#654 had to hold typescript at ^6.0.3 by hand because typescript-eslint refuses to load against TS 7. Without an ignore entry the weekly frontend group re-proposes the same upgrade and the PR goes red again every run. The boundary is 6.1, not 7: typescript-eslint's peer range is ">=4.8.4 <6.1.0", so 6.1 breaks `eslint .` the same way 7.0 does. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #654.
#654 held
typescriptat^6.0.3by hand becausetypescript-eslintrefuses to load against TS 7 (typescript-eslint does not support TS 7.0), which failseslint .in the frontend job. Without an ignore entry the weeklyfrontendgroup (patterns: ["*"]) re-proposes the same upgrade and the PR goes red again on every run — the pin alone is repeat work, not a fix.The boundary is 6.1, not 7:
typescript-eslint@8.65.0declarespeerDependencies.typescript: ">=4.8.4 <6.1.0", so a 6.1 bump breaks it exactly the same way. The ignore encodes that range rather than only the version we happened to hit.Removal condition is in the comment: drop the entry once typescript-eslint widens its peer range, and remove the
package.jsonpin with it.