Skip to content

allow to skip online tests#91

Closed
remicollet wants to merge 1 commit into
nette:v2.3from
remicollet:issue-inline
Closed

allow to skip online tests#91
remicollet wants to merge 1 commit into
nette:v2.3from
remicollet:issue-inline

Conversation

@remicollet
Copy link
Copy Markdown

Sometime we need to be able to run test suite from an offline computer (which, at least, is the case in Fedora build system).

The SKIP_ONLINE_TESTS env. variable is quite common (e.g. used in php test suite)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just

if (!getenv('SKIP_ONLINE_TESTS')) {
    FileSystem::copy('http://example.com', TEMP_DIR . '/3/x/y/file');
    Assert::true(is_file(TEMP_DIR . '/3/x/y/file'));
}

?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else is needed because '/3/x/y/file' is expected to exists in file "copy" test.

@milo
Copy link
Copy Markdown
Member

milo commented Nov 11, 2015

Alternative implementation #93

@remicollet remicollet mentioned this pull request Jun 2, 2016
@dg
Copy link
Copy Markdown
Member

dg commented Jun 17, 2016

Should be closed by #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants