allow to skip online tests#91
Closed
remicollet wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Why not just
if (!getenv('SKIP_ONLINE_TESTS')) {
FileSystem::copy('http://example.com', TEMP_DIR . '/3/x/y/file');
Assert::true(is_file(TEMP_DIR . '/3/x/y/file'));
}?
Author
There was a problem hiding this comment.
else is needed because '/3/x/y/file' is expected to exists in file "copy" test.
cddddd0 to
fbfaa9a
Compare
Member
|
Alternative implementation #93 |
Closed
Member
|
Should be closed by #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime we need to be able to run test suite from an offline computer (which, at least, is the case in Fedora build system).
The SKIP_ONLINE_TESTS env. variable is quite common (e.g. used in php test suite)