tests: added RemoteStream to be able test non-local URLs offline#93
Merged
Conversation
a1b06db to
2f4396f
Compare
Member
Author
|
@dg Not sure you know that this but |
Member
|
Error system in PHP is a tragedy… I do not know how to distinguish between errors that lead to failure from those that are just informative. I can either throw an exception for any error like here or throw an exception on failing return value and remove possible solution: #94 |
46f5434 to
ecbbdfc
Compare
ae4dce9 to
3d2aa29
Compare
Closed
dg
pushed a commit
that referenced
this pull request
Jun 17, 2016
# Conflicts: # tests/Utils/FileSystem.phpt
dg
pushed a commit
that referenced
this pull request
Jun 17, 2016
dg
pushed a commit
that referenced
this pull request
Jun 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.