Skip to content

tests: added RemoteStream to be able test non-local URLs offline#93

Merged
dg merged 1 commit into
nette:masterfrom
milo:pull-tests-remote
Jun 17, 2016
Merged

tests: added RemoteStream to be able test non-local URLs offline#93
dg merged 1 commit into
nette:masterfrom
milo:pull-tests-remote

Conversation

@milo
Copy link
Copy Markdown
Member

@milo milo commented Nov 11, 2015

No description provided.

@milo milo force-pushed the pull-tests-remote branch from a1b06db to 2f4396f Compare November 11, 2015 07:45
@milo milo mentioned this pull request Nov 11, 2015
@milo
Copy link
Copy Markdown
Member Author

milo commented Nov 11, 2015

@dg Not sure you know that this @ mutes:

E_WARNING: stream_copy_to_stream(): RemoteStream::stream_stat is not implemented!
E_WARNING: stream_copy_to_stream(): RemoteStream::stream_read is not implemented!
E_WARNING: stream_copy_to_stream(): RemoteStream::stream_eof is not implemented! Assuming EOF

but stream_copy_to_stream() returns 0 after that.

@dg
Copy link
Copy Markdown
Member

dg commented Nov 11, 2015

Error system in PHP is a tragedy…

I do not know how to distinguish between errors that lead to failure from those that are just informative. I can either throw an exception for any error like here or throw an exception on failing return value and remove @, so it will trigger warnings even exception will be catched.

possible solution: #94

@dg dg force-pushed the master branch 2 times, most recently from 46f5434 to ecbbdfc Compare December 3, 2015 12:21
@dg dg force-pushed the master branch 5 times, most recently from ae4dce9 to 3d2aa29 Compare April 21, 2016 13:00
@dg dg merged commit 8303fc2 into nette:master Jun 17, 2016
@dg dg mentioned this pull request Jun 17, 2016
dg pushed a commit that referenced this pull request Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants