This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Buffer Compaction #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Compaction makes more space available at the end of a buffer, by discarding bytes at the beginning that have already been processed. Modification: Add a copying compact method to Buf. Result: It is now possible to discard read bytes by calling `compact()`.
Motivation: The main use case with Buf.compact is in conjunction with ensureWritable. It turns out we can get a simpler API, and faster methods, by combining those two operations, because it allows us to relax some guarantees and skip some steps in certain cases, which wouldn't be as neat or clean if they were two separate steps. Modification: Add a new Buf.ensureWritable method, which takes an allowCompaction argument. In MemSegBuf, we can just delegate to compact() when applicable. In CompositeBuf, we can sometimes get away with just reorganising the bufs array. Result: We can now do ensureWritable without allocating in some cases, and this can in particular make the operation faster for CompositeBuf.
normanmaurer
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
compact()method, and anensureWritable()overload which may allow compaction.