This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Add support for iterating underlying buffer components #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's desirable to be able to access the contents of a Buf via an array or a ByteBuffer. However, we would also like to have a unified API that works for both composite and non-composite buffers. Even for nested composite buffers. Modification: Add a forEachReadable method, which uses internal iteration to process all buffer components. The internal iteration allows us to hide any nesting of composite buffers. The consumer in the internal iteration is presented with a Component object, which exposes the contents in various ways. The data is exposed from the Component via methods, such that anything that is expensive to create, will not have to be paid for unless it is used. This mechanism also let us avoid any allocation unnecessary allocation; the ByteBuffers and arrays will necessarily have to be allocated, but the consumer may or may not need allocation depending on how it's implemented, and the component objects do not need to be allocated, because the non-composite buffers can directly implement the Component interface. Result: It's now possible to access the contents of Buf instances as arrays or ByteBuffers, without having to copy the data.
chrisvest
force-pushed
the
buffer-iterate
branch
from
799859f to
d382017
Compare
Member
Author
|
We also need an equivalent |
normanmaurer
suggested changes
Jan 12, 2021
Pass iteration indexes through.
chrisvest
force-pushed
the
buffer-iterate
branch
from
f339cc9 to
46ed145
Compare
Member
Author
|
@normanmaurer How about this? |
Also add TODOs for flattening composite buffers.
normanmaurer
approved these changes
Jan 18, 2021
Member
normanmaurer
left a comment
normanmaurer
left a comment
There was a problem hiding this comment.
All in all this looks great... just some nits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's desirable to be able to access the contents of a Buf via an array or a ByteBuffer.
However, we would also like to have a unified API that works for both composite and non-composite buffers.
Even for nested composite buffers.
Modification:
Add a forEachReadable method, which uses internal iteration to process all buffer components.
The internal iteration allows us to hide any nesting of composite buffers.
The consumer in the internal iteration is presented with a Component object, which exposes the contents in various ways.
The data is exposed from the Component via methods, such that anything that is expensive to create, will not have to be paid for unless it is used.
This mechanism also let us avoid any allocation unnecessary allocation; the ByteBuffers and arrays will necessarily have to be allocated, but the consumer may or may not need allocation depending on how it's implemented, and the component objects do not need to be allocated, because the non-composite buffers can directly implement the Component interface.
Result:
It's now possible to access the contents of Buf instances as arrays or ByteBuffers, without having to copy the data.