This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Update examples #26
Merged
Update examples #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
approved these changes
Jan 25, 2021
| @Override | ||
| public int forEachWritable(int initialIndex, WritableComponentProcessor processor) { | ||
| public <E extends Exception> int forEachWritable(int initialIndex, WritableComponentProcessor<E> processor) | ||
| throws E { |
Motivation: The forEachReadable/Writable permit a cleaner FileCopyExample implementation. Modification: Simplify FileCopyExample. Also add examples of various good and bad ways to transfer buffer ownership between threads. Update the forEachReadable/Writable APIs to let exceptions pass through. Result: Cleaner code and more useful forEachReadable/Writable APIs.
chrisvest
force-pushed
the
update-examples
branch
from
f7877de to
2df000a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The forEachReadable/Writable permit a cleaner FileCopyExample implementation.
Modification:
Simplify FileCopyExample.
Also add examples of various good and bad ways to transfer buffer ownership between threads.
Update the forEachReadable/Writable APIs to let exceptions pass through.
Result:
Cleaner code and more useful forEachReadable/Writable APIs.