This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Make the incubating buffers exposable as ByteBuf #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvest
force-pushed
the
bytebuf-integration
branch
from
3e97c05 to
a18e320
Compare
Motivation: This makes it possible to use the new buffer API in Netty as is. Modification: Make the MemSegBuffer implementation class implement AsByteBuf and ReferenceCounted. The produced ByteBuf instance delegates all calls to the underlying Buffer instance as faithfully as possible. One area where the two deviates, is that it's not possible to create non-retained duplicates and slices with the new buffer API. Result: It is now possible to use the new buffer API on both client and server side. The Echo* examples demonstrate this, and the EchoIT proves it with a test. The API is used more directly on the client side, since the server-side allocator in Netty does not know how to allocate buffers with the incubating API.
chrisvest
force-pushed
the
bytebuf-integration
branch
from
a18e320 to
78f04ee
Compare
Member
Author
|
GitHub Actions is having an outage. Build passes locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This makes it possible to use the new buffer API in Netty as is.
Modification:
Make the MemSegBuffer implementation class implement ByteBufConvertible and ReferenceCounted.
The produced ByteBuf instance delegates all calls to the underlying Buffer instance as faithfully as possible.
One area where the two deviates, is that it's not possible to create non-retained duplicates and slices with the new buffer API.
Result:
It is now possible to use the new buffer API on both client and server side.
The Echo* examples demonstrate this, and the EchoIT proves it with a test.
The API is used more directly on the client side, since the server-side allocator in Netty does not know how to allocate buffers with the incubating API.
This is the companion PR to netty/netty#11036