Bug in BufferedWriteHandler fixed#618
Merged
Merged
Conversation
…er.java fix bug, flush variable was never reset
Member
|
@stefanmk didn't you also have a unit test for this ? |
Author
|
No, sorry, I do not have a unit test. We are using Netty in a server project, 3.5.7. complety broke it. With the fix all is working fine again. If you take a closer look at the code it is clear that the code cannot work and that there must be a bug. The flush variable is never set to false again, so after the first flush there cannot be a second one. |
Member
|
@stefanmk I thought I saw an unit test in the other pull-request that got closed.. anyway your fix looks good :) |
normanmaurer
added a commit
that referenced
this pull request
Sep 19, 2012
Bug in BufferedWriteHandler fixed
ghost
assigned
Closed
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Apr 2, 2025
Motivation: How we used QuicConnectEvent to notify about connection migration was not correct at all. Let's remove it for now as we will introduce something better once cloudflare/quiche#1660 was merged into quiche. Modifications: Remove QuicConnectEvent Result: Get rid of incorrect implementation to prepare for adding a proper one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flush variable in BufferedWriteHandler was never reset. This caused the buffer to only be flushed once and then never again. Bug was introduced in commit 88124d8. Without this fix BufferedWriteHandler is completely broken and useless as it doesn't work at all.