Fixed unexpected model generation bug.

[jiachen1120]

@NicholasAzar @stevehu
This PR is related to API-46 issue. Look forward to your review.

• Added schema type check
• Added properties number check

RFC for this issue: https://github.com/networknt/light-rfcs/blob/master/light-codegen/0003-model-generation-bug.md

[ddobrin]

Is this change backwards compatible with the classes generated by the light-codegen at this time?

[243826]

It looks like this fix introduces another bug where the name where the model generation for the types is suppressed but the types are not replaced with their corresponding primitive boxed types or array types. It results in non compiling code.

e.g. I had schemas

"UserId": {
  "type": "string",
   "minLength" : 8,
   "maxLength: 32
},
"Pair": {
  "type": "object",
  "required": [
      "primary",
      "secondary"
  ],
  "properties": {
     "primary" : {
        "$ref" : "#/components/schemas/UserId"
      },
     "secondary" : {
        "$ref" : "#/components/schemas/UserId"
      }
  }
}

I would get the following model for Pair

class Pair {
  UserId primary;
  UserId secondary;
  
  // irrelevant details deleted
}

but will not get the model for UserId. Obviously the code would not compile.

[jiachen1120]

@243826 Thank you for pointing this out. All property's types start with $ref at this stage will be set to its own name. This is incorrect and should be replaced with the type it references.

[stevehu]

@jiachen1120 @243826 There is a utility @ddobrin built to bundle multiple specification files and resolve the references in the components. I am wondering if we should try it out see what is the final spec before feeding it to the light-codegen.

[243826]

I can give it a shot. I was thinking probably I would need something like that soon. Could you help with more pointers?

…

On Sat, Feb 23, 2019, 9:39 AM Steve Hu ***@***.***> wrote: @jiachen1120 <https://github.com/jiachen1120> @243826 <https://github.com/243826> There is a utility @ddobrin <https://github.com/ddobrin> built to bundle multiple specification files and resolve the references in the components. I am wondering if we should try it out see what is the final spec before feeding it to the light-codegen. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#204 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACk9w2GSnHATLb0ohKYUDAXJgw8Q-k6zks5vQXzbgaJpZM4aK_Pf> .

[stevehu]

https://github.com/networknt/openapi-bundler is the repository and document is in the readme. In addition, this document might help. https://doc.networknt.com/development/best-practices/openapi3/#guidelines