Fix/#236 Uncompilable code generation caused by invalid variable name#237
Merged
Fix/#236 Uncompilable code generation caused by invalid variable name#237
Conversation
- fix invalid variable name, same variable name using java keywords - fix invalid generic in List and Map
- fix invalid enum name, some enum name is number - fix invalid variable name, same variable name using java keywords - fix invalid generic in List and Map
…into fix/#236-API-73
jiachen1120
changed the title
jiachen1120
changed the title
Member
|
@jiachen1120 could we use the |
- added comments
Member
|
@jiachen1120 could you resolve the conflicts on this? |
DSchrupert
reviewed
Mar 11, 2019
| private Map<String, String> typeMapping = new HashMap<>(); | ||
|
|
||
| private static List<String> javaKeyWordList = new ArrayList<>(Arrays.asList("abstract", "continue", "for", "new", | ||
| "switch", "assert", "default", "goto", "package", "synchronized", "boolean", "do", "if", "private", "this", |
Member
There was a problem hiding this comment.
Seems like you have different implementations of detecting java keywords between openapi and swagger now
Contributor
Author
There was a problem hiding this comment.
@NicholasAzar I forgot to update the swagger one, I will modify the swagger one to sync with openapi
DSchrupert
approved these changes
Mar 13, 2019
stevehu
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #236
Related RFC: https://github.com/networknt/light-rfcs/blob/master/light-codegen/0005-fix-uncompilable-generation-caused-by-naming.md
Related Jira ticket: API-73
Look forward to your reviews!