Skip to content

#158 binary format string - fix the handling of binary and byte formats of strings#248

Merged
stevehu merged 2 commits intonetworknt:issue248from
243826:158-binary-format-string
Mar 13, 2019
Merged

#158 binary format string - fix the handling of binary and byte formats of strings#248
stevehu merged 2 commits intonetworknt:issue248from
243826:158-binary-format-string

Conversation

@243826
Copy link
Copy Markdown
Contributor

@243826 243826 commented Mar 9, 2019

No description provided.

@243826 243826 changed the title 158 binary format string - fix the handling of binary and byte formats of strings #158 binary format string - fix the handling of binary and byte formats of strings Mar 9, 2019
@stevehu stevehu changed the base branch from develop to issue248 March 13, 2019 14:27
@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Mar 13, 2019

@243826 I have merged your code into issue248 branch in light-codegen to sync with the latest code from the develop branch. In the future, you can create a new branch in light-codegen for your contributions. It is much easier to sync with other people who are working on the same project. Thanks.

@stevehu stevehu merged commit 44d2a3f into networknt:issue248 Mar 13, 2019
stevehu added a commit that referenced this pull request Mar 13, 2019
…ts of strings (#248) (#252)

* optimized the format handling and converted to treating binary formats as byte[]

* handle the strings with binary and byte format properly
stevehu added a commit that referenced this pull request Mar 14, 2019
stevehu added a commit that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants