Conversation
|
Resolve #224 |
243826
left a comment
243826
left a comment
There was a problem hiding this comment.
are identical files checked into multiple locations? would be nice if they are kept in one place and referred to from multiple locations.
| mavenWrapperPropertyFileInputStream.close(); | ||
| } | ||
| } catch (IOException e) { | ||
| // Ignore ... |
There was a problem hiding this comment.
Why not declare main as throwing IOException and not swallow this?
| System.out.println("Done"); | ||
| System.exit(0); | ||
| } catch (Throwable e) { | ||
| System.out.println("- Error downloading"); |
There was a problem hiding this comment.
could clean up this file by letting the exception escape.
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <version.light-4j>1.5.18</version.light-4j> | ||
| <version.light-hybrid-4j>1.5.18</version.light-hybrid-4j> | ||
| <version.light-4j>1.5.32</version.light-4j> |
There was a problem hiding this comment.
not for this review but food for though - since 1.5.32 is not released, this should probably be 1.5.32-SNAPSHOT and should be uploaded to snapshot repository.
There was a problem hiding this comment.
It is always a good idea to have a snapshot version published and @NicholasAzar mentioned that before. There is still a lot of details we need to learn. Like where the snapshot version going to be published? How is maven going to figure out which version of the snapshot to be downloaded? What needs to be changed in the light-bot to support snapshot etc.
ddobrin
left a comment
ddobrin
left a comment
There was a problem hiding this comment.
Should we consider setting the default to:
https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.3/,
up from 0.4.2?
|
@ddobrin Thanks for the link. I will try the latest version. |
3 participants
No description provided.